-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add svc discoverer for readreplica svc #2263
Conversation
[CHATOPS:HELP] ChatOps commands.
|
[WARNING:INTCFG] Changes in |
38a54f0
to
44445bf
Compare
Deploying with Cloudflare Pages
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
==========================================
- Coverage 30.00% 29.78% -0.23%
==========================================
Files 370 372 +2
Lines 36089 36372 +283
==========================================
+ Hits 10829 10833 +4
- Misses 24747 25024 +277
- Partials 513 515 +2 ☔ View full report in Codecov by Sentry. |
32be1d3
to
cff4aad
Compare
cff4aad
to
b5cd858
Compare
Profile Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
I would appreciate it if you added a comment for each Global value/function that you implemented.
e.g.
- internal/k8s/service/...
files
- pkg
files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This PR
1. Addsinternal/k8s/readreplica/svc
to reconcile readreplica svc resourceinternal/k8s/svc
to reconcile svc resourcesRelated Issue:
Versions:
Checklist:
Special notes for your reviewer: