Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply make proto/all #2266

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Apply make proto/all #2266

merged 1 commit into from
Dec 7, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Dec 7, 2023

Description:

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.5

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 7, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

hlts2
hlts2 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM 💯

@hlts2 hlts2 merged commit b7b3c17 into main Dec 7, 2023
81 checks passed
@hlts2 hlts2 deleted the fix/buf/applyprotoall branch December 7, 2023 08:53
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
@ykadowak @kmrmt
Apply make proto/all (#2266)
8978f27
@vankichi vankichi mentioned this pull request Dec 19, 2023
Merged
This was referenced Jan 28, 2024
Open
Open
Open
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango approved these changes

@hlts2 hlts2 hlts2 approved these changes

Assignees
No one assigned
Labels
area/agent/core area/discoverer area/gateway/filter area/gateway/lb area/manager/index priority/low size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykadowak @vdaas-ci @kpango @hlts2