Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions deps to fix cache issue #2268

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Dec 8, 2023

Description:

I've updated buildkit version for vald docker image build.
And bump actions/checkout@v3 to v4.

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.5

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 8, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@github-actions github-actions bot added team/sre SRE team type/ci size/S type/bug Something isn't working labels Dec 8, 2023
@kpango kpango force-pushed the bugfix/actions/docker-login-to-ghcr branch from df0ec75 to 9aa7b34 Compare December 8, 2023 08:02
Copy link

cloudflare-pages bot commented Dec 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a0806b9
Status: ✅  Deploy successful!
Preview URL: https://8eb125af.vald.pages.dev
Branch Preview URL: https://bugfix-actions-docker-login.vald.pages.dev

View logs

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the bugfix/actions/docker-login-to-ghcr branch from 9aa7b34 to a0806b9 Compare December 8, 2023 08:07
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9cd436e) 29.97% compared to head (a0806b9) 29.99%.
Report is 10 commits behind head on main.

Files Patch % Lines
hack/license/gen/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
+ Coverage   29.97%   29.99%   +0.01%     
==========================================
  Files         370      370              
  Lines       36085    36089       +4     
==========================================
+ Hits        10818    10824       +6     
- Misses      24752    24753       +1     
+ Partials      515      512       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ykadowak ykadowak changed the title change login user and token for ghcr.io & small refactor Update actions deps to fix cache issue Dec 8, 2023
@ykadowak ykadowak merged commit 84d2ab1 into main Dec 8, 2023
109 of 110 checks passed
@ykadowak ykadowak deleted the bugfix/actions/docker-login-to-ghcr branch December 8, 2023 08:24
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
ykadowak pushed a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants