[bugfix] gRPC pool connection health check for DNS Addr may fail during VIP member disconnection #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/internal
size/M
type/bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
- Coverage 30.02% 29.99% -0.04%
==========================================
Files 371 371
Lines 36089 36115 +26
==========================================
- Hits 10837 10832 -5
- Misses 24738 24770 +32
+ Partials 514 513 -1 ☔ View full report in Codecov by Sentry. |
kpango
force-pushed
the
bugfix/internal-grpc/A-Record-health-check-failure-during-target-vip-member-restarts
branch
from
d8ca6ff
to
c40b91a
Compare
Deploying with
|
| Latest commit: |
8c61bfb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7f8b7182.vald.pages.dev |
| Branch Preview URL: | https://bugfix-internal-grpc-a-recor.vald.pages.dev |
kpango
force-pushed
the
bugfix/internal-grpc/A-Record-health-check-failure-during-target-vip-member-restarts
branch
3 times, most recently
from
4c391b4
to
2c374b3
Compare
…ng VIP member disconnection fix Signed-off-by: kpango <kpango@vdaas.org>
kpango
force-pushed
the
bugfix/internal-grpc/A-Record-health-check-failure-during-target-vip-member-restarts
branch
from
2c374b3
to
bd15979
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if !p.isIP && p.resolveDNS && hash != nil && *hash != "" { | ||
| ips, err := p.lookupIPAddr(ctx) | ||
| if err != nil { | ||
| return p, nil |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
error is not nil (line 392) but it returns nil (nilerr)
Profile Report
|
kpango
requested review from
a team,
kmrmt and
hlts2
and removed request for
a team
kmrmt
approved these changes
Dec 21, 2023
hlts2
approved these changes
Dec 22, 2023
…ailure-during-target-vip-member-restarts
kpango
deleted the
bugfix/internal-grpc/A-Record-health-check-failure-during-target-vip-member-restarts
branch
This was referenced Jan 28, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SSIA
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: