Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy New Year 2024 #2284

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Happy New Year 2024 #2284

merged 1 commit into from
Dec 31, 2023

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Dec 31, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy new year 🎊 Vald

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd2c92b) 29.98% compared to head (e64d1de) 30.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
+ Coverage   29.98%   30.00%   +0.02%     
==========================================
  Files         371      371              
  Lines       36126    36126              
==========================================
+ Hits        10831    10841      +10     
+ Misses      24781    24773       -8     
+ Partials      514      512       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy New Year!
LGTM!! 👍

@hlts2 hlts2 merged commit a4459f1 into main Dec 31, 2023
131 of 133 checks passed
@hlts2 hlts2 deleted the happy-new-year-2024 branch December 31, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants