Make vald-readreplica values.yaml to symbolic link #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
vankichi
approved these changes
Jan 5, 2024
kpango
approved these changes
Jan 9, 2024
ykadowak
added a commit
that referenced
this pull request
Jan 10, 2024
* remove values.yaml * Add symlink to values.yaml
ykadowak
added a commit
that referenced
this pull request
Jan 10, 2024
* remove values.yaml * Add symlink to values.yaml
ykadowak
added a commit
that referenced
this pull request
Jan 16, 2024
* remove values.yaml * Add symlink to values.yaml
ykadowak
added a commit
that referenced
this pull request
Jan 19, 2024
* remove values.yaml * Add symlink to values.yaml
ykadowak
added a commit
that referenced
this pull request
Jan 19, 2024
* Make vald-readreplica values.yaml to symbolic link (#2286) * remove values.yaml * Add symlink to values.yaml * Stop initializing read replica clinet when it's disabled by config * Add topologySpreadConstraints for read replica deployment * Refactor GetReadReplica API * Refactor LB configuration and add ReadReplicaClient definition * Refactor discovererOpts variable declaration * Add podAffinityTerm to avoid deployment on the same node as agent and other readreplica pods * Refactor comments * skip cyclomatic complexity warning * Add unit tests for GetReadClient() method in client package * Refactor discovererOpts function and add unit tests * Refactor discovererOpts function to return discoverer client
This was referenced Jan 28, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SSIA. I forgot to do this.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: