Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable disconnection during non-IP-direct connection #2291

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jan 10, 2024

Description:

Same as #2288

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

Signed-off-by: kpango <kpango@vdaas.org>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango requested review from a team, vankichi and ykadowak and removed request for a team January 10, 2024 06:44
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f555a94
Status: ✅  Deploy successful!
Preview URL: https://abca3555.vald.pages.dev
Branch Preview URL: https://refactor-internal-grpc-fix-c.vald.pages.dev

View logs

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (3ef2f35) 29.96% compared to head (f555a94) 29.95%.

Files Patch % Lines
internal/net/grpc/client.go 0.00% 16 Missing ⚠️
internal/net/grpc/pool/pool.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
- Coverage   29.96%   29.95%   -0.01%     
==========================================
  Files         371      371              
  Lines       36152    36165      +13     
==========================================
+ Hits        10833    10835       +2     
- Misses      24804    24817      +13     
+ Partials      515      513       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ykadowak
Copy link
Contributor

Let's merge after e2e passes just in case.

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@ykadowak ykadowak merged commit ac50bf3 into main Jan 10, 2024
183 of 189 checks passed
@ykadowak ykadowak deleted the refactor/internal-grpc/fix-connection-cycle branch January 10, 2024 08:55
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants