Add internal KVS pogreb package #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying with
|
| Latest commit: |
c98c4c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a8ba8127.vald.pages.dev |
| Branch Preview URL: | https://feature-internal-add-kvs-pog.vald.pages.dev |
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/internal
size/L
type/feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2302 +/- ##
==========================================
+ Coverage 30.15% 30.20% +0.05%
==========================================
Files 389 391 +2
Lines 40826 40927 +101
==========================================
+ Hits 12310 12362 +52
- Misses 27863 27900 +37
- Partials 653 665 +12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/feature%2Finternal%2Fadd-kvs-pogreb/397a1dcafaffa58bf4e1fcb44539741aac636eac |
Profile Report
|
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
hlts2
requested review from
a team,
vankichi and
datelier
and removed request for
a team
datelier
previously approved these changes
Jan 23, 2024
Co-authored-by: datelier <57349093+datelier@users.noreply.github.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
datelier
approved these changes
Jan 24, 2024
vankichi
approved these changes
Jan 24, 2024
This was referenced Jan 28, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I added an internal
pogresKVS package.This package will be used to provide metadata functions in the future.
At this stage, the implementation is simple for the time being, as use cases for metadata functionality have not yet been determined. We plan to add or modify missing features in the future.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: