Stop using ENV ARCH and add --platform in Dockerfile #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
| Latest commit: |
085f31e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d961bb3.vald.pages.dev |
| Branch Preview URL: | https://feature-dockerfile-no-use-en.vald.pages.dev |
ykadowak
changed the title
ykadowak
requested review from
vankichi,
a team and
kpango
and removed request for
a team
This was referenced Jan 28, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The ENV ARCH was unnecessary, and the definition of unnecessary environment variables can have side effects, so removed them. Additionally, added the --platform option to Dockerfiles that were missing it.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: