Change to dynamically switch CI container image tag #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/sre
Deploying with
|
| Latest commit: |
dc5eea7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a412e43.vald.pages.dev |
| Branch Preview URL: | https://refactor-ci-use-ci-container.vald.pages.dev |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2310 +/- ##
=======================================
Coverage 30.29% 30.30%
=======================================
Files 391 391
Lines 40945 40945
=======================================
+ Hits 12404 12407 +3
+ Misses 27876 27874 -2
+ Partials 665 664 -1 ☔ View full report in Codecov by Sentry. |
vankichi
approved these changes
Jan 29, 2024
This was referenced Feb 1, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, we always use the nightly image, even if an image tag is created for the CI container.
The CI fails when the Go version is upgraded, so I changed it so that if a tagged image is created, workflow will use that tag.
The following are the failing workflows.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: