Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k3d connectivity error #2317

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix k3d connectivity error #2317

merged 2 commits into from
Feb 1, 2024

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Feb 1, 2024

Description:

I fixed to connect to k3d cluster from CI container using host.docker.internal.

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 self-assigned this Feb 1, 2024
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 1, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Copy link

cloudflare-pages bot commented Feb 1, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b2c24b
Status: ✅  Deploy successful!
Preview URL: https://8e47aeaa.vald.pages.dev
Branch Preview URL: https://fix-ci-k3d.vald.pages.dev

View logs

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2
Copy link
Contributor Author

hlts2 commented Feb 1, 2024

I checked for problems with the following PR and it was working properly 🙏

#2318
CI: https://github.com/vdaas/vald/actions/runs/7740281220/job/21104911833?pr=2318

@vankichi vankichi merged commit 2a5261c into main Feb 1, 2024
20 of 21 checks passed
@vankichi vankichi deleted the fix/ci/k3d branch February 1, 2024 11:38
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants