New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE]: Debug for format-diff job #2321

Closed

hlts2 wants to merge 3 commits into main from fix/ci/cargo

Contributor

hlts2 commented Feb 6, 2024

Description:

As titled

Related Issue:

Versions:

Go Version: 1.21.5
Docker Version: 20.10.8
Kubernetes Version: v1.28.4
NGT Version: 2.1.6

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

kpango and others added 3 commits

February 6, 2024 13:30


          refactor update opentelemetry-go & faiss

76c1447

Signed-off-by: kpango <kpango@vdaas.org>


          fix: debug for env

cc4b21b

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>


          fix: image tag

487ce50

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

cloudflare-pages bot commented Feb 6, 2024 •

edited

Loading

Deploying with Cloudflare Pages

Latest commit:	`487ce50`
Status:	✅ Deploy successful!
Preview URL:	https://c0e4f68c.vald.pages.dev
Branch Preview URL:	https://fix-ci-cargo.vald.pages.dev

github-actions bot reviewed

View reviewed changes

dockers/agent/core/faiss/Dockerfile

+              ENV APP_NAME faiss
+              # skipcq: DOK-DL3008
+              RUN apt-get update && apt-get install -y --no-install-recommends \

Contributor

github-actions bot Feb 6, 2024

⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

Collaborator

vdaas-ci commented Feb 6, 2024

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

Collaborator

vdaas-ci commented Feb 6, 2024

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions bot reviewed

View reviewed changes

docs/tutorial/get-started-with-faiss-agent.md

+                 gateway:
+                   lb:
+                     ...
+                     ingress:

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Ingress
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                     ingress:
+                       enabled: true
+                       # TODO: Set your ingress host.
+                       host: localhost

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Host
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                       # TODO: Set your ingress host.
+                       host: localhost
+                       # TODO: Set annotations which you have to set for your k8s cluster.
+                       annotations:

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Annotations
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                 Deploy vald on your Kubernetes cluster.
+                 ```bash
+                 helm install vald vald/vald --values example/helm/values.yaml

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: vald
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

docs/tutorial/get-started-with-faiss-agent.md

+                  <details><summary>The detailed explanation of example code is here</summary><br>
+                  This will execute 6 steps.
+.  init

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Init
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                          <details><summary>example code</summary><br>
+                        ```go
+                        for i := range ids [:insertCount] {

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                        for i := range ids [:insertCount] {
+                            _, err := client.Insert(ctx, &payload.Insert_Request{
+                                Vector: &payload.Object_Vector{
+                                    Id:     ids[i],

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                                glg.Fatal(err)
+                            }
+                            b, _ := json.MarshalIndent(res.GetResults(), "", " ")

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: B
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                          <details><summary>example code</summary><br>
+                        ```go
+                        for i := range ids [:insertCount] {

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

docs/tutorial/get-started-with-faiss-agent.md

+                        for i := range ids [:insertCount] {
+                            _, err := client.Remove(ctx, &payload.Remove_Request{
+                                Id: &payload.Object_ID{
+                                    Id: ids[i],

Contributor

github-actions bot Feb 6, 2024

[LanguageTool] _{reported by reviewdog 🐶}
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING

github-actions bot added the priority/low label

codecov bot commented Feb 6, 2024 •

edited

Loading

Codecov Report

Attention: 428 lines in your changes are missing coverage. Please review.

Comparison is base (adf1b61) 30.29% compared to head (487ce50) 30.30%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
...ternal/observability/metrics/agent/core/ngt/ngt.go	0.00%	105 Missing ⚠️
...nal/observability/metrics/agent/sidecar/sidecar.go	0.00%	45 Missing ⚠️
...ability/metrics/index/job/correction/correction.go	0.00%	39 Missing ⚠️
...ernal/observability/metrics/manager/index/index.go	0.00%	39 Missing ⚠️
internal/observability/metrics/grpc/grpc.go	0.00%	22 Missing ⚠️
...rvability/metrics/circuitbreaker/circuitbreaker.go	0.00%	20 Missing ⚠️
internal/observability/metrics/backoff/backoff.go	0.00%	19 Missing ⚠️
...servability/metrics/runtime/goroutine/goroutine.go	0.00%	19 Missing ⚠️
internal/config/faiss.go	0.00%	18 Missing ⚠️
internal/observability/metrics/runtime/cgo/cgo.go	0.00%	18 Missing ⚠️
... and 17 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2321   +/-   ##
=======================================
  Coverage   30.29%   30.30%           
=======================================
  Files         391      393    +2     
  Lines       40953    40954    +1     
=======================================
+ Hits        12408    12411    +3     
+ Misses      27882    27878    -4     
- Partials      663      665    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hlts2 closed this

hlts2 deleted the fix/ci/cargo branch

February 6, 2024 07:45

This was referenced Mar 1, 2024

Monthly review time metrics report: 2024-02-01..2024-02-29 ykadowak/actions-test#11

Closed

Monthly review time metrics report: 2024-02-01..2024-02-29 #2429

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment