-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix golangci-lint config and apply tagalign #2323
Conversation
Signed-off-by: kpango <kpango@vdaas.org>
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
Latest commit: |
dccec0b
|
Status: | ✅ Deploy successful! |
Preview URL: | https://bec7c3c7.vald.pages.dev |
Branch Preview URL: | https://feature-lint-update.vald.pages.dev |
[WARNING:INTCFG] Changes in |
@@ -46,6 +48,12 @@ import ( | |||
"github.com/vdaas/vald/internal/sync/errgroup" | |||
"github.com/vdaas/vald/pkg/agent/internal/kvs" | |||
"github.com/vdaas/vald/pkg/agent/internal/metadata" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
File is not gofumpt
-ed (gofumpt)
pkg/agent/core/ngt/service/ngt.go
Outdated
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
"k8s.io/apimachinery/pkg/fields" | ||
kruntime "k8s.io/apimachinery/pkg/runtime" | ||
applycorev1 "k8s.io/client-go/applyconfigurations/core/v1" | ||
"github.com/vdaas/vald/pkg/agent/internal/vqueue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
File is not gofumpt
-ed (gofumpt)
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
"k8s.io/apimachinery/pkg/labels" | ||
"k8s.io/apimachinery/pkg/runtime" | ||
"k8s.io/apimachinery/pkg/selection" | ||
"k8s.io/apimachinery/pkg/watch" | ||
clientgoscheme "k8s.io/client-go/kubernetes/scheme" | ||
"k8s.io/utils/pointer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
"k8s.io/apimachinery/pkg/labels" | ||
"k8s.io/apimachinery/pkg/runtime" | ||
"k8s.io/apimachinery/pkg/selection" | ||
"k8s.io/apimachinery/pkg/watch" | ||
clientgoscheme "k8s.io/client-go/kubernetes/scheme" | ||
"k8s.io/utils/pointer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
==========================================
- Coverage 30.30% 28.72% -1.58%
==========================================
Files 393 383 -10
Lines 40954 38610 -2344
==========================================
- Hits 12410 11090 -1320
+ Misses 27879 27016 -863
+ Partials 665 504 -161 ☔ View full report in Codecov by Sentry. |
b56ae7d
to
141515a
Compare
Description:
.golangci-lint.yaml
for updated style.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: