Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e regressions #2327

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Fix e2e regressions #2327

merged 5 commits into from
Feb 7, 2024

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Feb 7, 2024 •
edited
Loading

Description:

#2303 changed agent name from vald-agent-ngt to vald-agent, and it broke the e2e tests. This PR fixes it.

Related Issue:

Versions:

  • Go Version: 1.21.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.1
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Feb 7, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10520c7
Status: ✅  Deploy successful!
Preview URL: https://8c065613.vald.pages.dev
Branch Preview URL: https://fix-e2e-vald-deploy.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 7, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@ykadowak ykadowak changed the title [WIP] Fix to deploy vald-agent-config Fix e2e regressions Feb 7, 2024
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 7, 2024

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@ykadowak ykadowak marked this pull request as ready for review February 7, 2024 07:29
@ykadowak ykadowak requested review from a team, kmrmt and datelier and removed request for a team and datelier February 7, 2024 07:30
kmrmt
kmrmt previously approved these changes Feb 7, 2024
View reviewed changes
kpango
kpango reviewed Feb 7, 2024
View reviewed changes
Makefile.d/k8s.mk Outdated Show resolved Hide resolved
@ykadowak ykadowak requested review from kpango and kmrmt February 7, 2024 08:16
kpango
kpango approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

@ykadowak ykadowak merged commit 619df34 into main Feb 7, 2024
36 checks passed
@ykadowak ykadowak deleted the fix/e2e/vald-deploy branch February 7, 2024 09:40
This was referenced Feb 15, 2024
Merged
Merged
This was referenced Mar 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmrmt kmrmt kmrmt approved these changes

@kpango kpango kpango approved these changes

@vankichi vankichi vankichi approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling area/makefile priority/low size/S type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ykadowak @vdaas-ci @kmrmt @kpango @vankichi