Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite yaml format #2330

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Feb 8, 2024

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.21.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.1
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 8, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpango kpango merged commit 5492f9d into dependencies/update-go-deps Feb 8, 2024
117 checks passed
@kpango kpango deleted the bugfix/wf/infinite-yaml-format branch February 8, 2024 02:37
vankichi added a commit that referenced this pull request Feb 8, 2024
…#2322)

* format yaml using google/yamlfmt & update go version and dependencies

Signed-off-by: kpango <kpango@vdaas.org>

* 🐛 Fix infinite yaml format (#2330)

Signed-off-by: vankichi <kyukawa315@gmail.com>

* fix: add dictionaly to detect target image tag (#2331)

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants