-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate component build error #2341
Merged
kpango
merged 7 commits into
bugfix/docker/gcc-environment-for-arm
from
investigate/bugfix/docker/gcc-environment-for-arm
Feb 10, 2024
Merged
Investigate component build error #2341
kpango
merged 7 commits into
bugfix/docker/gcc-environment-for-arm
from
investigate/bugfix/docker/gcc-environment-for-arm
Feb 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
[CHATOPS:HELP] ChatOps commands.
|
dockers/agent/core/ngt/Dockerfile
Outdated
@@ -85,7 +85,14 @@ COPY .git . | |||
COPY go.mod . | |||
COPY go.sum . | |||
|
|||
RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \ | |||
RUN if [ "${TARGETARCH}" = "amd64" ] ; then \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dockers/agent/core/ngt/Dockerfile
Outdated
@@ -110,7 +117,14 @@ COPY versions . | |||
WORKDIR ${GOPATH}/src/github.com/${ORG}/${REPO} | |||
RUN make ngt/install | |||
|
|||
RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \ | |||
RUN if [ "${TARGETARCH}" = "amd64" ] ; then \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying with
|
Latest commit: |
a0cba9e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2d0f0c9e.vald.pages.dev |
Branch Preview URL: | https://investigate-bugfix-docker-gc.vald.pages.dev |
kpango
approved these changes
Feb 10, 2024
6bc0591
into
bugfix/docker/gcc-environment-for-arm
128 of 129 checks passed
kpango
added a commit
that referenced
this pull request
Feb 13, 2024
fix: env Revert "fix: env" Investigate component build error (#2341) Merge branch 'main' into bugfix/docker/gcc-environment-for-arm fix: buildplatform to targetplatform fix: deleted unnecessary environment variable Signed-off-by: kpango <kpango@vdaas.org>
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As titled
Related Issue
Versions
Checklist
Special notes for your reviewer