Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate component build error #2341

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Feb 9, 2024

Description

As titled

Related Issue

Versions

  • Go Version: 1.22.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.1
  • NGT Version: 2.1.6

Checklist

Special notes for your reviewer

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 9, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@@ -85,7 +85,14 @@ COPY .git .
COPY go.mod .
COPY go.sum .

RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
RUN if [ "${TARGETARCH}" = "amd64" ] ; then \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <SC2140> reported by reviewdog 🐶
Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A"B"C"?

@@ -110,7 +117,14 @@ COPY versions .
WORKDIR ${GOPATH}/src/github.com/${ORG}/${REPO}
RUN make ngt/install

RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
RUN if [ "${TARGETARCH}" = "amd64" ] ; then \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <SC2140> reported by reviewdog 🐶
Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A"B"C"?

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Copy link

cloudflare-pages bot commented Feb 9, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a0cba9e
Status: ✅  Deploy successful!
Preview URL: https://2d0f0c9e.vald.pages.dev
Branch Preview URL: https://investigate-bugfix-docker-gc.vald.pages.dev

View logs

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
This reverts commit ee8b964.
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 changed the title [DO NOT MERGE]: Investigate component build error Investigate component build error Feb 10, 2024
@hlts2 hlts2 marked this pull request as ready for review February 10, 2024 05:16
@kpango kpango merged commit 6bc0591 into bugfix/docker/gcc-environment-for-arm Feb 10, 2024
128 of 129 checks passed
@kpango kpango deleted the investigate/bugfix/docker/gcc-environment-for-arm branch February 10, 2024 05:19
kpango added a commit that referenced this pull request Feb 13, 2024
fix: env
Revert "fix: env"
Investigate component build error (#2341)
Merge branch 'main' into bugfix/docker/gcc-environment-for-arm
fix: buildplatform to targetplatform
fix: deleted unnecessary environment variable

Signed-off-by: kpango <kpango@vdaas.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants