Add Con-Bench helm chart to the Vald charts repository #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vankichi
requested review from
a team,
kpango and
hlts2
and removed request for
a team
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
type/ci
area/helm
area/makefile
size/M
type/refactoring
priority/low
labels
ykadowak
reviewed
Feb 19, 2024
ykadowak
reviewed
Feb 19, 2024
|
|
||
| A benchmark operator for benchmarking the Vald cluster. | ||
| Current chart version is `v1.7.5` |
kpango
dismissed
hlts2’s stale review
The merge-base changed after approval.
Deploying with
|
| Latest commit: |
061218d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1feceb34.vald.pages.dev |
| Branch Preview URL: | https://refactor-helm-add-continous.vald.pages.dev |
Signed-off-by: kpango <kpango@vdaas.org> Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
vankichi
force-pushed
the
refactor/helm/add-continous-benchmark-for-helm-package
branch
from
cdaa778
to
e7999c9
Compare
ykadowak
reviewed
Feb 19, 2024
| @@ -32,7 +32,7 @@ appVersion: "1.16.0" | |||
|
|
|||
| apiVersion: v2 | |||
| name: vald-benchmark-operator | |||
| version: v1.7.5 | |||
| version: v1.7.11 | |||
There was a problem hiding this comment.
version needs to be updated by ci like below
vald/.github/workflows/_release-pr.yml
Line 77 in 9b088e3
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer