Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement client metrics interceptor for continuous benchmark job #2477

Merged
merged 9 commits into from
Apr 22, 2024

:recycle: Fix format

211f27c
Select commit
Failed to load commit list.
Merged

Implement client metrics interceptor for continuous benchmark job #2477

:recycle: Fix format
211f27c
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Apr 22, 2024 in 0s

18.94% (+0.03%) compared to 63b53ea

View this Pull Request on Codecov

18.94% (+0.03%) compared to 63b53ea

Details

Codecov Report

Attention: Patch coverage is 34.78261% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 18.94%. Comparing base (63b53ea) to head (211f27c).
Report is 1 commits behind head on main.

Files Patch % Lines
...ernal/net/grpc/interceptor/client/metric/metric.go 0.00% 42 Missing ⚠️
pkg/tools/benchmark/job/usecase/benchmarkd.go 0.00% 16 Missing ⚠️
pkg/tools/benchmark/operator/service/option.go 21.42% 9 Missing and 2 partials ⚠️
internal/net/grpc/option.go 0.00% 9 Missing ⚠️
pkg/tools/benchmark/operator/usecase/benchmarkd.go 0.00% 4 Missing ⚠️
pkg/tools/benchmark/operator/config/config.go 0.00% 3 Missing ⚠️
internal/config/benchmark.go 0.00% 2 Missing ⚠️
...rnal/k8s/vald/benchmark/job/job_template_option.go 71.42% 1 Missing and 1 partial ⚠️
pkg/tools/benchmark/job/config/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2477      +/-   ##
==========================================
+ Coverage   18.90%   18.94%   +0.03%     
==========================================
  Files         562      563       +1     
  Lines       64595    64707     +112     
==========================================
+ Hits        12214    12257      +43     
- Misses      51585    51652      +67     
- Partials      796      798       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov