fix tensorflow.go, option.go #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan
|
kpango
reviewed
Feb 28, 2020
| @@ -26,7 +26,9 @@ type SessionOptions = tf.SessionOptions | |||
| type Operation = tf.Operation | |||
|
|
|||
| type TF interface { | |||
| GetVector(feeds []Feed, fetches []Fetch, targets ...*Operation) (values [][][]float64, err error) | |||
| GetVector(feeds []Feed, fetch Fetch, targets ...*Operation) ([]float64, error) | |||
There was a problem hiding this comment.
Suggested change
| GetVector(feeds []Feed, fetch Fetch, targets ...*Operation) ([]float64, error) | |
| GetVector(seeds ...[]byte) ([]float64, error) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| for _, result := range results { | ||
| value, ok := result.Value().([][]float64) | ||
| switch t.ndim { | ||
| case 2: |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
mnd: Magic number: 2, in detected (gomnd)
| } else { | ||
| return nil, errors.ErrFailedToCastTF(tensors[0].Value()) | ||
| } | ||
| case 3: |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
mnd: Magic number: 3, in detected (gomnd)
kpango
reviewed
Apr 23, 2020
| } | ||
| const ( | ||
| TWO_DIM int8 = 2 | ||
| THREE_DIM int8 = 3 |
There was a problem hiding this comment.
In golang const value we shouldn't use snake case please use camel case, and I recommend below
Suggested change
| THREE_DIM int8 = 3 | |
| NoDim uint8 = iota | |
| OneDim | |
| TwoDim | |
| ThreeDim |
Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>
Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>
Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>
Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>
Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>
|
/rebase |
|
[REBASE] Rebase triggered by kpango for branch: feature/tensorflow |
|
[REBASE] Failed to rebase. |
datelier
force-pushed
the
feature/tensorflow
branch
from
6603044
to
4eeda50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: datelier 57349093+datelier@users.noreply.github.com
Description:
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: