-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix slice init length #2672
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request involve a modification to the Changes
Sequence Diagram(s)sequenceDiagram
participant gRPCClient
participant ConnectionMonitor
gRPCClient->>ConnectionMonitor: StartConnectionMonitor()
ConnectionMonitor->>gRPCClient: Initialize addrs slice
gRPCClient->>ConnectionMonitor: Append addresses to addrs
ConnectionMonitor->>gRPCClient: Monitor connections
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
==========================================
+ Coverage 23.97% 23.99% +0.01%
==========================================
Files 539 539
Lines 47195 47195
==========================================
+ Hits 11317 11325 +8
+ Misses 35109 35098 -11
- Partials 769 772 +3 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Description
The intention here should be to initialize a slice with a capacity of len(g.addrs) rather than initializing the length of this slice.
The online demo: https://go.dev/play/p/q1BcVCmvidW
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit