Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix slice init length #2672

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: fix slice init length #2672

merged 2 commits into from
Oct 4, 2024

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Oct 4, 2024

Description

The intention here should be to initialize a slice with a capacity of len(g.addrs) rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

Related Issue

Versions

  • Vald Version: v1.7.13
  • Go Version: v1.23.2
  • Rust Version: v1.81.0
  • Docker Version: v27.3.1
  • Kubernetes Version: v1.31.1
  • Helm Version: v3.16.1
  • NGT Version: v2.2.4
  • Faiss Version: v1.8.0

Checklist

Special notes for your reviewer

Summary by CodeRabbit

  • Bug Fixes
    • Improved memory optimization for address handling in connection monitoring, enhancing performance during connection processes.

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

coderabbitai bot commented Oct 4, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request involve a modification to the StartConnectionMonitor method of the gRPCClient struct in the internal/net/grpc/client.go file. The initialization of the addrs slice has been updated from a fixed-length slice to a dynamically sized slice, allowing for optimized memory usage when appending addresses. This change does not affect the method's logic or overall functionality, as no new methods were introduced and existing method signatures remain unchanged.

Changes

File Change Summary
internal/net/grpc/client.go Modified StartConnectionMonitor: changed addrs initialization from fixed-length to dynamically sized slice.

Sequence Diagram(s)

sequenceDiagram
    participant gRPCClient
    participant ConnectionMonitor

    gRPCClient->>ConnectionMonitor: StartConnectionMonitor()
    ConnectionMonitor->>gRPCClient: Initialize addrs slice
    gRPCClient->>ConnectionMonitor: Append addresses to addrs
    ConnectionMonitor->>gRPCClient: Monitor connections
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kpango kpango merged commit 4c5caca into vdaas:main Oct 4, 2024
147 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 4, 2024
2 tasks
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.99%. Comparing base (da446c0) to head (2bb30da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/net/grpc/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
+ Coverage   23.97%   23.99%   +0.01%     
==========================================
  Files         539      539              
  Lines       47195    47195              
==========================================
+ Hits        11317    11325       +8     
+ Misses      35109    35098      -11     
- Partials      769      772       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

takuyaymd pushed a commit to takuyaymd/vald that referenced this pull request Dec 2, 2024
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
takuyaymd pushed a commit to takuyaymd/vald that referenced this pull request Dec 2, 2024
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants