Backport PR #2713 to release/v1.7 for Multi-PF build for example-client image

[vdaas-ci]

Description

SSIA

Related Issue

Versions

• Vald Version: v1.7.13
• Go Version: v1.23.2
• Rust Version: v1.81.0
• Docker Version: v27.3.1
• Kubernetes Version: v1.31.1
• Helm Version: v3.16.2
• NGT Version: v2.2.4
• Faiss Version: v1.9.0

Checklist

• I have read the CONTRIBUTING document and completed our CLA agreement.
• I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

• New Features
  • Enhanced Docker image build process to support multiple architectures (linux/amd64 and linux/arm64), improving compatibility across different environments.

[cloudflare-workers-and-pages]

Deploying vald with    Cloudflare Pages

Latest commit:	2a60a69
Status:	✅  Deploy successful!
Preview URL:	https://029054a6.vald.pages.dev
Branch Preview URL:	https://backport-release-v1-7-ci-mak.vald.pages.dev

View logs

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the GitHub Actions workflow for building a Docker image for the example client by adding a new input parameter, platforms, to the build job. This parameter specifies the target platforms as linux/amd64 and linux/arm64, enabling the workflow to create Docker images compatible with both AMD64 and ARM64 architectures. The remaining aspects of the workflow, including event triggers and monitored paths, remain unchanged.

Changes

File Path	Change Summary
.github/workflows/dockers-example-client-image.yaml	Added platforms: linux/amd64,linux/arm64 parameter in build job.

Possibly related PRs

• Multi-PF build for example-client image #2713: This PR adds a platforms parameter to the GitHub Actions workflow for building the Docker image, which directly relates to the change made in the main PR that also introduces the platforms parameter for multi-architecture support.
• Backport PR #2705 to release/v1.7 for add example-client docker image #2709: This PR includes modifications to the same workflow file (dockers-example-client-image.yaml) as the main PR, focusing on building the example-client Docker image, which is relevant to the changes made in the main PR.

Suggested labels

priority/low, type/ci, size/S

Suggested reviewers

• kpango
• vankichi

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

.github/workflows/dockers-example-client-image.yaml (1)

Line range hint 1-77: Architecture suggestion: Consider caching strategy for multi-platform builds.

While the multi-platform build configuration is correct, building for multiple architectures can significantly increase build times. Consider implementing layer caching strategies in the reusable workflow to optimize build performance.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c845e81 and 2a60a69.

📒 Files selected for processing (1)

• .github/workflows/dockers-example-client-image.yaml (1 hunks)

🔇 Additional comments (1)

.github/workflows/dockers-example-client-image.yaml (1)

76-76: LGTM! Multi-platform build configuration looks good.

The addition of platforms: linux/amd64,linux/arm64 aligns with the PR objective to enable Multi-Platform builds for the example-client image. This change will allow the image to run natively on both Intel/AMD and ARM-based systems.

Let's verify that the reusable workflow supports the platforms parameter:

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test