Fix typo for docker.mk #2720
Fix typo for docker.mk #2720
Conversation
Signed-off-by: vankichi <kyukawa315@gmail.com>
📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
vankichi
requested review from
a team,
kpango and
datelier
and removed request for
a team
|
[CHATOPS:HELP] ChatOps commands.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- Makefile.d/docker.mk (3 hunks)
🔇 Additional comments (3)
Makefile.d/docker.mk (3)
375-375: LGTM! Correct HDF5 version reference for benchmark-job image.The build argument now correctly references HDF5_VERSION instead of HDF4_VERSION.
Let's verify the corresponding Dockerfile uses this argument:
#!/bin/bash # Check if the Dockerfile actually uses HDF5_VERSION rg -l 'ARG HDF5_VERSION' dockers/tools/benchmark/job/
398-398: LGTM! Correct HDF5 version reference for example-client image.The build argument now correctly references HDF5_VERSION instead of HDF4_VERSION.
Let's verify the corresponding Dockerfile uses this argument:
#!/bin/bash # Check if the Dockerfile actually uses HDF5_VERSION rg -l 'ARG HDF5_VERSION' dockers/example/client/
Line range hint
307-398: Verify HDF5_VERSION variable is defined.The changes look good, but we should ensure the HDF5_VERSION variable is properly defined.
Let's check if HDF5_VERSION is defined in the Makefile:
#!/bin/bash # Check where HDF5_VERSION is defined rg 'HDF5_VERSION[:=]' Makefile.d/
| @@ -304,7 +304,7 @@ docker/name/loadtest: | |||
| ## build loadtest image | |||
| docker/build/loadtest: | |||
| @make DOCKERFILE="$(ROOTDIR)/dockers/tools/cli/loadtest/Dockerfile" \ | |||
| DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \ | |||
| DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \ | |||
There was a problem hiding this comment.
💡 Codebase verification
Warning: HDF5_VERSION build argument is not used in the Dockerfile
The Dockerfile for the loadtest image does not use the HDF5_VERSION build argument that's being passed in the Makefile. Instead, it installs HDF5 using make hdf5/install without referencing the version argument. This suggests a potential issue where the build argument is being passed but not utilized.
dockers/tools/cli/loadtest/Dockerfile: Usesmake hdf5/installwithout version specificationMakefile.d/docker.mk:307: Passes unused--build-arg HDF5_VERSION=$(HDF5_VERSION)
🔗 Analysis chain
LGTM! Correct HDF5 version reference for loadtest image.
The build argument now correctly references HDF5_VERSION instead of HDF4_VERSION.
Let's verify the corresponding Dockerfile uses this argument:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the Dockerfile actually uses HDF5_VERSION
rg -l 'ARG HDF5_VERSION' dockers/tools/cli/loadtest/
Length of output: 591
Script:
#!/bin/bash
# Let's try to find the Dockerfile for loadtest and check its content
fd Dockerfile dockers/tools/cli/loadtest/
# Also search for any Dockerfile that uses HDF5_VERSION
fd Dockerfile | xargs rg "ARG HDF5_VERSION"
Length of output: 127
Script:
#!/bin/bash
# Let's examine the content of the loadtest Dockerfile
cat dockers/tools/cli/loadtest/Dockerfile
Length of output: 3562
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit