Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2843 to release/v1.7 for Update license headers / Format codes #2844

Conversation

vdaas-ci
Copy link
Collaborator

@vdaas-ci vdaas-ci commented Feb 12, 2025

Update license headers / Format Go codes and YAML files.

Summary by CodeRabbit

  • New Features

    • Introduced enhanced configuration options for scaling, resource management, and observability.
    • Added an end-to-end testing workflow to validate maximum dimension insert functionality.
  • CI/CD Pipeline Updates

    • Standardized workflow naming, refined trigger events, and improved secrets management for build and deployment processes.
  • Chores

    • Removed redundant comments and obsolete default sections from configuration and chart files to streamline setups and maintenance.

Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2025

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 07c62cb
Status: ✅  Deploy successful!
Preview URL: https://4cdc245a.vald.pages.dev
Branch Preview URL: https://backport-release-v1-7-format-i5vi.vald.pages.dev

View logs

Copy link
Contributor

coderabbitai bot commented Feb 12, 2025

📝 Walkthrough

Walkthrough

This pull request applies extensive cleanup and configuration updates across numerous YAML files. Most changes involve the removal of comment lines, licensing headers, and default configuration blocks from helm values, charts, and GitHub Actions workflows. Several workflows have been modified by removing explicit names or autogenerated comments, with minor trigger adjustments and one new end-to-end testing workflow added. In addition, key chart configurations have been updated with new parameters for scaling, logging, and observability.

Changes

Files Change Summary
.fossa.yml, .github/helm/values/values-agent-sidecar.yaml, .github/helm/values/values-chaos.yaml, .github/helm/values/values-max-dim.yaml, .github/helm/values/values-mirror-01.yaml, .github/helm/values/values-mirror-02.yaml, .github/helm/values/values-profile.yaml, .github/helm/values/values-readreplica.yaml, .github/valdrelease/valdrelease.yaml, .github/workflows/reviewdog.yaml, charts/vald-benchmark-operator/schemas/job-values.yaml, charts/vald-helm-operator/Chart.yaml, charts/vald-helm-operator/values.yaml, charts/vald-readreplica/Chart.yaml, charts/vald/Chart.yaml, charts/vald/schemas/mirror-target-values.yaml, charts/vald/values/dev-observability.yaml, tests/chaos/chart/Chart.yaml, tests/chaos/chart/values.yaml Removed comment blocks, licensing headers, and extraneous formatting that do not affect functionality.
.github/helm/values/values-correction.yaml, .github/helm/values/values-index-management-jobs.yaml, .github/helm/values/values-lb.yaml, charts/vald/values/agent-ngt-standalone.yaml, charts/vald/values/dev-broken-index-backup.yaml, example/helm/values-standalone-agent-ngt.yaml Deleted blocks of default settings and configuration sections (e.g., defaults, agent/manager settings) to change how configurations are managed.
.github/workflows/dockers-*.yaml, .github/workflows/reviewdog-hadolint.yaml, .github/workflows/reviewdog-k8s.yaml, .github/workflows/reviewdog-markdown.yaml, .github/workflows/e2e-max-dim.yaml Removed workflow name lines and autogenerated comments; adjusted triggers (e.g. adding pull_request_target); introduced a new E2E testing workflow and updated reviewdog workflows with refined linting patterns and additional jobs.
charts/vald/values.yaml, example/helm/values-with-pyroscope.yaml, example/helm/values.yaml Updated chart configurations by adding new parameters (e.g. minReplicas, maxReplicas, maxUnavailable, observability, and auto-index settings) and removed deprecated annotations.

Sequence Diagram(s)

sequenceDiagram
  participant Trigger as "GitHub Actions Trigger"
  participant Checkout as "Repo Checkout"
  participant Detector as "CI Container Detector"
  participant E2E as "E2E Test Executor"
  participant Slack as "Slack Notifier"

  Trigger->>Checkout: Trigger on tag or PR label
  Checkout->>Detector: Provide repository context
  Detector->>E2E: Initiate E2E tests loop (varying bit dimensions)
  E2E->>E2E: Deploy Vald agent and run tests until termination condition
  E2E->>Slack: Send completion notification
Loading
sequenceDiagram
  participant PR as "Pull Request"
  participant Checkout as "Repo Checkout"
  participant Dump as "Dump Context Job"
  participant Lint as "Lint Jobs (kubeval, kubelinter, etc.)"

  PR->>Checkout: Initiate reviewdog workflow on manifest changes
  Checkout->>Dump: Dump context for analysis
  Dump->>Lint: Execute linting steps for Kubernetes manifests
Loading

Possibly related PRs

Suggested labels

actions/backport/release/v1.7, priority/low, type/ci, size/XXXL

Suggested reviewers

  • kpango
  • vankichi

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38f71b2 and 07c62cb.

📒 Files selected for processing (61)
  • .fossa.yml (0 hunks)
  • .github/helm/values/values-agent-sidecar.yaml (0 hunks)
  • .github/helm/values/values-chaos.yaml (0 hunks)
  • .github/helm/values/values-correction.yaml (0 hunks)
  • .github/helm/values/values-index-management-jobs.yaml (0 hunks)
  • .github/helm/values/values-lb.yaml (0 hunks)
  • .github/helm/values/values-max-dim.yaml (0 hunks)
  • .github/helm/values/values-mirror-01.yaml (0 hunks)
  • .github/helm/values/values-mirror-02.yaml (0 hunks)
  • .github/helm/values/values-profile.yaml (0 hunks)
  • .github/helm/values/values-readreplica.yaml (0 hunks)
  • .github/valdrelease/valdrelease.yaml (0 hunks)
  • .github/workflows/dockers-agent-faiss-image.yaml (0 hunks)
  • .github/workflows/dockers-agent-image.yaml (0 hunks)
  • .github/workflows/dockers-agent-ngt-image.yaml (0 hunks)
  • .github/workflows/dockers-agent-sidecar-image.yaml (0 hunks)
  • .github/workflows/dockers-benchmark-job-image.yaml (0 hunks)
  • .github/workflows/dockers-benchmark-operator-image.yaml (0 hunks)
  • .github/workflows/dockers-binfmt-image.yaml (0 hunks)
  • .github/workflows/dockers-buildbase-image.yaml (0 hunks)
  • .github/workflows/dockers-buildkit-image.yaml (0 hunks)
  • .github/workflows/dockers-buildkit-syft-scanner-image.yaml (0 hunks)
  • .github/workflows/dockers-ci-container-image.yaml (0 hunks)
  • .github/workflows/dockers-dev-container-image.yaml (0 hunks)
  • .github/workflows/dockers-discoverer-k8s-image.yaml (0 hunks)
  • .github/workflows/dockers-example-client-image.yaml (0 hunks)
  • .github/workflows/dockers-gateway-filter-image.yaml (0 hunks)
  • .github/workflows/dockers-gateway-lb-image.yaml (0 hunks)
  • .github/workflows/dockers-gateway-mirror-image.yaml (0 hunks)
  • .github/workflows/dockers-helm-operator-image.yaml (0 hunks)
  • .github/workflows/dockers-index-correction-image.yaml (0 hunks)
  • .github/workflows/dockers-index-creation-image.yaml (0 hunks)
  • .github/workflows/dockers-index-deletion-image.yaml (0 hunks)
  • .github/workflows/dockers-index-operator-image.yaml (0 hunks)
  • .github/workflows/dockers-index-save-image.yaml (0 hunks)
  • .github/workflows/dockers-loadtest-image.yaml (0 hunks)
  • .github/workflows/dockers-manager-index-image.yaml (0 hunks)
  • .github/workflows/dockers-readreplica-rotate-image.yaml (0 hunks)
  • .github/workflows/e2e-max-dim.yaml (0 hunks)
  • .github/workflows/reviewdog-hadolint.yaml (0 hunks)
  • .github/workflows/reviewdog-k8s.yaml (0 hunks)
  • .github/workflows/reviewdog-markdown.yaml (0 hunks)
  • .github/workflows/reviewdog.yaml (0 hunks)
  • charts/vald-benchmark-operator/schemas/job-values.yaml (0 hunks)
  • charts/vald-benchmark-operator/schemas/scenario-values.yaml (0 hunks)
  • charts/vald-benchmark-operator/values.yaml (0 hunks)
  • charts/vald-helm-operator/Chart.yaml (0 hunks)
  • charts/vald-helm-operator/values.yaml (0 hunks)
  • charts/vald-readreplica/Chart.yaml (0 hunks)
  • charts/vald/Chart.yaml (0 hunks)
  • charts/vald/schemas/mirror-target-values.yaml (0 hunks)
  • charts/vald/values.yaml (0 hunks)
  • charts/vald/values/agent-ngt-standalone.yaml (0 hunks)
  • charts/vald/values/dev-broken-index-backup.yaml (0 hunks)
  • charts/vald/values/dev-observability.yaml (0 hunks)
  • charts/vald/values/dev.yaml (0 hunks)
  • example/helm/values-standalone-agent-ngt.yaml (0 hunks)
  • example/helm/values-with-pyroscope.yaml (0 hunks)
  • example/helm/values.yaml (0 hunks)
  • tests/chaos/chart/Chart.yaml (0 hunks)
  • tests/chaos/chart/values.yaml (0 hunks)
💤 Files with no reviewable changes (61)
  • .fossa.yml
  • .github/workflows/dockers-ci-container-image.yaml
  • .github/helm/values/values-readreplica.yaml
  • .github/valdrelease/valdrelease.yaml
  • .github/helm/values/values-chaos.yaml
  • .github/workflows/dockers-buildkit-image.yaml
  • .github/helm/values/values-correction.yaml
  • charts/vald/Chart.yaml
  • .github/workflows/dockers-example-client-image.yaml
  • .github/helm/values/values-profile.yaml
  • .github/workflows/dockers-helm-operator-image.yaml
  • charts/vald-helm-operator/Chart.yaml
  • .github/helm/values/values-lb.yaml
  • charts/vald/schemas/mirror-target-values.yaml
  • .github/workflows/dockers-binfmt-image.yaml
  • .github/workflows/dockers-buildkit-syft-scanner-image.yaml
  • .github/helm/values/values-mirror-01.yaml
  • example/helm/values-with-pyroscope.yaml
  • .github/workflows/dockers-agent-ngt-image.yaml
  • .github/workflows/reviewdog-hadolint.yaml
  • .github/workflows/dockers-agent-faiss-image.yaml
  • .github/workflows/dockers-agent-image.yaml
  • .github/workflows/dockers-index-deletion-image.yaml
  • .github/workflows/dockers-index-correction-image.yaml
  • charts/vald-benchmark-operator/schemas/job-values.yaml
  • .github/workflows/dockers-index-creation-image.yaml
  • .github/workflows/dockers-dev-container-image.yaml
  • .github/workflows/dockers-discoverer-k8s-image.yaml
  • tests/chaos/chart/values.yaml
  • .github/helm/values/values-max-dim.yaml
  • .github/helm/values/values-mirror-02.yaml
  • .github/workflows/dockers-agent-sidecar-image.yaml
  • tests/chaos/chart/Chart.yaml
  • .github/workflows/dockers-gateway-filter-image.yaml
  • charts/vald/values/dev.yaml
  • .github/workflows/reviewdog.yaml
  • charts/vald/values/dev-observability.yaml
  • .github/workflows/dockers-gateway-mirror-image.yaml
  • charts/vald-helm-operator/values.yaml
  • .github/workflows/dockers-loadtest-image.yaml
  • charts/vald-readreplica/Chart.yaml
  • .github/workflows/dockers-manager-index-image.yaml
  • .github/workflows/dockers-buildbase-image.yaml
  • .github/workflows/dockers-index-operator-image.yaml
  • .github/helm/values/values-agent-sidecar.yaml
  • .github/workflows/dockers-readreplica-rotate-image.yaml
  • .github/workflows/dockers-benchmark-operator-image.yaml
  • .github/helm/values/values-index-management-jobs.yaml
  • .github/workflows/reviewdog-markdown.yaml
  • example/helm/values-standalone-agent-ngt.yaml
  • charts/vald-benchmark-operator/schemas/scenario-values.yaml
  • .github/workflows/dockers-gateway-lb-image.yaml
  • charts/vald/values/dev-broken-index-backup.yaml
  • charts/vald/values/agent-ngt-standalone.yaml
  • .github/workflows/dockers-index-save-image.yaml
  • .github/workflows/dockers-benchmark-job-image.yaml
  • example/helm/values.yaml
  • charts/vald-benchmark-operator/values.yaml
  • .github/workflows/e2e-max-dim.yaml
  • .github/workflows/reviewdog-k8s.yaml
  • charts/vald/values.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vdaas-ci
Copy link
Collaborator Author

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi merged commit fc54c85 into release/v1.7 Feb 12, 2025
190 of 191 checks passed
@vankichi vankichi deleted the backport/release/v1.7/formatter/go_and_yaml/format_at_20250212_060457_217 branch February 12, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants