create test template for using gotests #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan (4 warnings)
|
|
[WARNING] Changes in |
github-actions
bot
added
area/agent
area/discoverer
area/gateway
area/manager/backup
area/manager/index
area/manager/replication
area/meta
team/set
|
/rebase |
|
[REBASE] Rebase triggered by vankichi for branch: test/cmd-hack-internal-pkg/gen-missing-test-by-template-using-gotests |
|
[REBASE] Failed to rebase. |
vankichi
force-pushed
the
test/cmd-hack-internal-pkg/gen-missing-test-by-template-using-gotests
branch
from
cf63529
to
b12abfa
Compare
|
[WARNING] Changes in |
1 similar comment
|
[WARNING] Changes in |
|
[WARNING] Changes in |
1 similar comment
|
[WARNING] Changes in |
|
/rebase |
|
[REBASE] Rebase triggered by vankichi for branch: test/cmd-hack-internal-pkg/gen-missing-test-by-template-using-gotests |
vdaas-ci
force-pushed
the
test/cmd-hack-internal-pkg/gen-missing-test-by-template-using-gotests
branch
from
48b9fda
to
cc27f84
Compare
|
[WARNING] Changes in |
|
/rebase |
|
[REBASE] Rebase triggered by vankichi for branch: test/cmd-hack-internal-pkg/gen-missing-test-by-template-using-gotests |
|
here are the examples: pkg/manager/replication/controller/handler/rest/handler_test.go//
// Copyright (C) 2019-2020 Vdaas.org Vald team ( kpango, rinx, kmrmt )
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// Package rest provides rest api logic
package rest
import (
"net/http"
"reflect"
"testing"
"github.com/cockroachdb/errors"
"github.com/vdaas/vald/apis/grpc/manager/replication/controller"
)
func TestNew(t *testing.T) {
type args struct {
opts []Option
}
type want struct {
want Handler
}
type test struct {
name string
args args
want want
checkFunc func(want, Handler) error
beforeFunc func(args)
afterFunc func(args)
}
defaultCheckFunc := func(w want, got Handler) error {
if !reflect.DeepEqual(got, w.want) {
return errors.Errorf("got = %v, want %v", got, w.want)
}
return nil
}
tests := []test{
// TODO test cases
/*
{
name: "test_case_1",
args: args {
opts: nil,
},
want: want{},
checkFunc: defaultCheckFunc,
},
*/
// TODO test cases
/*
func() test {
return test {
name: "test_case_2",
args: args {
opts: nil,
},
want: want{},
checkFunc: defaultCheckFunc,
}
}(),
*/
}
for _, test := range tests {
t.Run(test.name, func(tt *testing.T) {
if test.beforeFunc != nil {
test.beforeFunc(test.args)
}
if test.afterFunc != nil {
defer test.afterFunc(test.args)
}
if test.checkFunc == nil {
test.checkFunc = defaultCheckFunc
}
got := New(test.args.opts...)
if err := test.checkFunc(test.want, got); err != nil {
tt.Errorf("error = %v", err)
}
})
}
}
func Test_handler_Index(t *testing.T) {
type args struct {
w http.ResponseWriter
r *http.Request
}
type fields struct {
rpl controller.ReplicationServer
}
type want struct {
want int
err error
}
type test struct {
name string
args args
fields fields
want want
checkFunc func(want, int, error) error
beforeFunc func(args)
afterFunc func(args)
}
defaultCheckFunc := func(w want, got int, err error) error {
if !errors.Is(err, w.err) {
return errors.Errorf("got error = %v, want %v", err, w.err)
}
if !reflect.DeepEqual(got, w.want) {
return errors.Errorf("got = %v, want %v", got, w.want)
}
return nil
}
tests := []test{
// TODO test cases
/*
{
name: "test_case_1",
args: args {
w: nil,
r: nil,
},
fields: fields {
rpl: nil,
},
want: want{},
checkFunc: defaultCheckFunc,
},
*/
// TODO test cases
/*
func() test {
return test {
name: "test_case_2",
args: args {
w: nil,
r: nil,
},
fields: fields {
rpl: nil,
},
want: want{},
checkFunc: defaultCheckFunc,
}
}(),
*/
}
for _, test := range tests {
t.Run(test.name, func(tt *testing.T) {
if test.beforeFunc != nil {
test.beforeFunc(test.args)
}
if test.afterFunc != nil {
defer test.afterFunc(test.args)
}
if test.checkFunc == nil {
test.checkFunc = defaultCheckFunc
}
h := &handler{
rpl: test.fields.rpl,
}
got, err := h.Index(test.args.w, test.args.r)
if err := test.checkFunc(test.want, got, err); err != nil {
tt.Errorf("error = %v", err)
}
})
}
}pkg/manager/replication/controller/handler/rest/option_test.go//
// Copyright (C) 2019-2020 Vdaas.org Vald team ( kpango, rinx, kmrmt )
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// Package rest provides rest api logic
package rest
import (
"testing"
"github.com/vdaas/vald/apis/grpc/manager/replication/controller"
)
func TestWithReplicator(t *testing.T) {
type T = interface{}
type args struct {
rpl controller.ReplicationServer
}
type want struct {
obj *T
// Uncomment this line if the option returns an error, otherwise delete it
// err error
}
type test struct {
name string
args args
want want
// Use the first line if the option returns an error. otherwise use the second line
// checkFunc func(want, *T, error) error
// checkFunc func(want, *T) error
beforeFunc func(args)
afterFunc func(args)
}
// Uncomment this block if the option returns an error, otherwise delete it
/*
defaultCheckFunc := func(w want, obj *T, err error) error {
if !errors.Is(err, w.err) {
return errors.Errorf("got error = %v, want %v", err, w.err)
}
if !reflect.DeepEqual(obj, w.obj) {
return errors.Errorf("got = %v, want %v", obj, w.obj)
}
return nil
}
*/
// Uncomment this block if the option do not returns an error, otherwise delete it
/*
defaultCheckFunc := func(w want, obj *T) error {
if !reflect.DeepEqual(obj, w.obj) {
return fmt.Errorf("got = %v, want %v", obj, w.c)
}
return nil
}
*/
tests := []test{
// TODO test cases
/*
{
name: "test_case_1",
args: args {
rpl: nil,
},
want: want {
obj: new(T),
},
},
*/
// TODO test cases
/*
func() test {
return test {
name: "test_case_2",
args: args {
rpl: nil,
},
want: want {
obj: new(T),
},
}
}(),
*/
}
for _, test := range tests {
t.Run(test.name, func(tt *testing.T) {
if test.beforeFunc != nil {
test.beforeFunc(test.args)
}
if test.afterFunc != nil {
defer test.afterFunc(test.args)
}
// Uncomment this block if the option returns an error, otherwise delete it
/*
if test.checkFunc == nil {
test.checkFunc = defaultCheckFunc
}
got := WithReplicator(test.args.rpl)
obj := new(T)
if err := test.checkFunc(test.want, obj, got(obj)); err != nil {
tt.Errorf("error = %v", err)
}
*/
// Uncomment this block if the option returns an error, otherwise delete it
/*
if test.checkFunc == nil {
test.checkFunc = defaultCheckFunc
}
got := WithReplicator(test.args.rpl)
obj := new(T)
got(obj)
if err := test.checkFunc(tt.want, obj); err != nil {
tt.Errorf("error = %v", err)
}
*/
})
}
} |
|
@vdaas/set LGTM you guys did a great job! |
|
/rebase |
|
[REBASE] Rebase triggered by kpango for branch: test/cmd-hack-internal-pkg/gen-missing-test-by-template-using-gotests |
|
[FORMAT] Updating license headers and formatting go codes triggered by kpango. |
Signed-off-by: vdaas-ci <ci@vdaas.org>
vdaas-ci
previously approved these changes
Apr 24, 2020
This reverts commit d95f55e.
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
/format |
|
[FORMAT] Updating license headers and formatting go codes triggered by kpango. |
Signed-off-by: vdaas-ci <ci@vdaas.org>
vdaas-ci
approved these changes
Apr 24, 2020
kpango
deleted the
test/cmd-hack-internal-pkg/gen-missing-test-by-template-using-gotests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vankichi kyukawa315@gmail.com
Description:
I added make command and testing template for generating missing test files using gotests .
This PR is related to #325
Note:
We will update the below test files using our template.
Missing test files are below (check filled test file will be generated):
files
Related Issue:
#325
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: