Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor vald-helm-operator Helm Chart #334

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Apr 16, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

This PR includes these features.

Related Issue:

#330

How Has This Been Tested?:

Nothing.

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Apr 16, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ✨ Add more options and remove valdhelmoperatorrelease, valdre...

Powered by Pull Assistant. Last update 4cfe1e0 ... 4cfe1e0. Read the comment docs.

@rinx
Copy link
Contributor Author

rinx commented Apr 26, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by rinx for branch: refactor/helm-operaotr/remove-vhor-from-chart

…om vald-helm-operator chart

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the refactor/helm-operaotr/remove-vhor-from-chart branch from 99a7362 to 4cfe1e0 Compare April 26, 2020 13:30
@rinx rinx marked this pull request as ready for review April 26, 2020 13:31
@rinx rinx added the team/sre SRE team label Apr 26, 2020
@github-actions github-actions bot removed the team/sre SRE team label Apr 26, 2020
@rinx rinx added the team/sre SRE team label Apr 26, 2020
@rinx rinx requested review from hlts2 and kpango April 27, 2020 01:25
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit daab561 into master Apr 27, 2020
@kpango kpango deleted the refactor/helm-operaotr/remove-vhor-from-chart branch April 27, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An issue on self-management functionality of Vald-Helm-operator
3 participants