Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Resolve busy-loop on worker #339

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Apr 20, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Resolve worker busy loop.
And fixed metrics definitions.

Related Issue:

compressor uses CPU too much, i've profiled using pprof.
スクリーンショット 2020-04-20 14 34 34

it shows worker.queue.pop occupies the large amount of CPU.

How Has This Been Tested?:

On my k8s cluster.

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Apr 20, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ♻️ Resolve busy-loop on worker

     📈 Fix metrics definitions

     🤖 Update license headers and formatting go codes

Powered by Pull Assistant. Last update 58d9ed3 ... bba700c. Read the comment docs.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx marked this pull request as ready for review April 20, 2020 06:27
@rinx
Copy link
Contributor Author

rinx commented Apr 20, 2020

It's ready for review. @kpango
The compressor metrics now returns actual values.

@rinx rinx requested a review from kpango April 20, 2020 06:30
@kpango
Copy link
Collaborator

kpango commented Apr 20, 2020

LGTM
/format
/approve

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

Signed-off-by: vdaas-ci <ci@vdaas.org>
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

@kpango kpango merged commit d58015b into master Apr 20, 2020
@kpango kpango deleted the refactor/compressor/resolve-busy-loop branch April 20, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants