Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Compressor: backup vectors in queue using PostStop function #345

Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Apr 21, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Currently, vectors in registerer queue are send to other compressor during PreStop function in shutdown process.
However, it may be an issue that vectors in queue lost with terminating pods.
In this PR, backup processes will be run during PostStop function in shutdown process.

Related Issue:

Nothing.

How Has This Been Tested?:

my K8s cluster.

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Apr 21, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ♻️ backup vectors in queue during poststop function

     🔧 longer terminationGracePeriodSeconds for compressor

Powered by Pull Assistant. Last update e416339 ... ca03423. Read the comment docs.

@rinx rinx marked this pull request as ready for review April 21, 2020 09:36
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@kpango
Copy link
Collaborator

kpango commented Apr 21, 2020

LGTM
/format
/approve

@vdaas-ci
Copy link
Collaborator

[FORMAT] Failed to format.

@kpango kpango merged commit 258574e into master Apr 21, 2020
@kpango kpango deleted the refactor/compressor/backup-vectors-in-queue-poststop-fn branch April 21, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants