Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create missing test files by the our original test template #348

Merged
merged 33 commits into from
Apr 24, 2020
Merged

create missing test files by the our original test template #348

merged 33 commits into from
Apr 24, 2020

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Apr 24, 2020 •
edited
Loading

Description:

I added missing test files using by the our original templates via gotests
But, it's difficult to set our original packages (ex: internal/errors) through using our templates.
So, we (vald/set team) decided to fix each file each time when it is generated with incorrect pkg.

generated files are below:

files
  • cmd/agent/ngt/main_test.go
  • cmd/discoverer/k8s/main_test.go
  • cmd/gateway/vald/main_test.go
  • cmd/manager/backup/cassandra/main_test.go
  • cmd/manager/backup/mysql/main_test.go
  • cmd/manager/compressor/main_test.go
  • cmd/manager/index/main_test.go
  • cmd/manager/replication/agent/main_test.go
  • cmd/manager/replication/controller/main_test.go
  • cmd/meta/cassandra/main_test.go
  • cmd/meta/redis/main_test.go
  • hack/benchmark/core/benchmark/benchmark_test.go
  • hack/benchmark/core/benchmark/option_test.go
  • hack/benchmark/core/benchmark/strategy/bulk_insert_commit_test.go
  • hack/benchmark/core/benchmark/strategy/bulk_insert_test.go
  • hack/benchmark/core/benchmark/strategy/get_vector_test.go
  • hack/benchmark/core/benchmark/strategy/insert_commit_test.go
  • hack/benchmark/core/benchmark/strategy/insert_test.go
  • hack/benchmark/core/benchmark/strategy/remove_test.go
  • hack/benchmark/core/benchmark/strategy/search_test.go
  • hack/benchmark/core/benchmark/strategy/strategy_option_test.go
  • hack/benchmark/core/benchmark/strategy/strategy_test.go
  • hack/benchmark/core/benchmark/strategy/util_test.go
  • hack/benchmark/internal/assets/dataset_test.go
  • hack/benchmark/internal/assets/loader_test.go
  • hack/benchmark/internal/client/ngtd/grpc/client_test.go
  • hack/benchmark/internal/client/ngtd/grpc/option_test.go
  • hack/benchmark/internal/client/ngtd/rest/client_test.go
  • hack/benchmark/internal/client/ngtd/rest/option_test.go
  • hack/benchmark/internal/core/gongt/gongt_test.go
  • hack/benchmark/internal/core/gongt/option_test.go
  • hack/benchmark/internal/core/ngt/ngt_test.go
  • hack/benchmark/internal/core/ngt/option_test.go
  • hack/benchmark/internal/e2e/e2e_test.go
  • hack/benchmark/internal/e2e/option_test.go
  • hack/benchmark/internal/e2e/strategy/create_index_option_test.go
  • hack/benchmark/internal/e2e/strategy/create_index_test.go
  • hack/benchmark/internal/e2e/strategy/insert_option_test.go
  • hack/benchmark/internal/e2e/strategy/insert_test.go
  • hack/benchmark/internal/e2e/strategy/remove_option_test.go
  • hack/benchmark/internal/e2e/strategy/remove_test.go
  • hack/benchmark/internal/e2e/strategy/search_option_test.go
  • hack/benchmark/internal/e2e/strategy/search_test.go
  • hack/benchmark/internal/e2e/strategy/stream_insert_test.go
  • hack/benchmark/internal/e2e/strategy/stream_remove_test.go
  • hack/benchmark/internal/e2e/strategy/stream_search_option_test.go
  • hack/benchmark/internal/e2e/strategy/stream_search_test.go
  • hack/benchmark/internal/starter/agent/ngt/ngt_test.go
  • hack/benchmark/internal/starter/agent/ngt/option_test.go
  • hack/benchmark/internal/starter/external/ngtd/ngtd_test.go
  • hack/benchmark/internal/starter/external/ngtd/option_test.go
  • hack/benchmark/internal/starter/gateway/vald/vald_test.go
  • hack/license/gen/main_test.go
  • hack/swagger/main_test.go
  • hack/tools/config/agent/ngt/main_test.go
  • hack/tools/config/discoverer/k8s/main_test.go
  • hack/tools/config/gateway/vald/main_test.go
  • hack/tools/config/manager/backup/mysql/main_test.go
  • hack/tools/config/meta/redis/main_test.go
  • hack/tools/metrics/main_test.go
  • internal/backoff/backoff_test.go
  • internal/backoff/option_test.go
  • internal/cache/cache_test.go
  • internal/cache/cacher/cacher_test.go
  • internal/cache/gache/gache_test.go
  • internal/cache/gache/option_test.go
  • internal/cache/option_test.go
  • internal/client/agent/ngt/grpc/client_test.go
  • internal/client/agent/ngt/grpc/option_test.go
  • internal/client/agent/ngt/rest/client_test.go
  • internal/client/agent/ngt/rest/option_test.go
  • internal/client/compressor/client_test.go
  • internal/client/compressor/option_test.go
  • internal/client/discoverer/discover_test.go
  • internal/client/discoverer/option_test.go
  • internal/client/gateway/vald/grpc/client_test.go
  • internal/client/gateway/vald/grpc/option_test.go
  • internal/client/gateway/vald/rest/client_test.go
  • internal/client/gateway/vald/rest/option_test.go
  • internal/compress/gob_test.go
  • internal/compress/gzip_option_test.go
  • internal/compress/gzip_test.go
  • internal/compress/lz4_option_test.go
  • internal/compress/lz4_test.go
  • internal/compress/zstd_option_test.go
  • internal/compress/zstd_test.go
  • internal/config/backoff_test.go
  • internal/config/backup_test.go
  • internal/config/cassandra_test.go
  • internal/config/client_test.go
  • internal/config/compress_test.go
  • internal/config/config_test.go
  • internal/config/debug_test.go
  • internal/config/discoverer_test.go
  • internal/config/filter_test.go
  • internal/config/gateway_test.go
  • internal/config/grpc_test.go
  • internal/config/index_test.go
  • internal/config/log_test.go
  • internal/config/meta_test.go
  • internal/config/mysql_test.go
  • internal/config/ngt_test.go
  • internal/config/observability_test.go
  • internal/config/redis_test.go
  • internal/config/server_test.go
  • internal/config/tcp_test.go
  • internal/config/tls_test.go
  • internal/config/transport_test.go
  • internal/core/converter/tensorflow/option_test.go
  • internal/core/converter/tensorflow/tensorflow_test.go
  • internal/core/ngt/ngt_test.go
  • internal/db/kvs/redis/option_test.go
  • internal/db/kvs/redis/redis_test.go
  • internal/db/nosql/cassandra/cassandra_test.go
  • internal/db/nosql/cassandra/conviction_test.go
  • internal/db/nosql/cassandra/option_test.go
  • internal/db/rdb/mysql/model_test.go
  • internal/db/rdb/mysql/mysql_test.go
  • internal/db/rdb/mysql/option_test.go
  • internal/errgroup/group_test.go
  • internal/errors/cassandra_test.go
  • internal/errors/mysql_test.go
  • internal/errors/redis_test.go
  • internal/info/info_test.go
  • internal/k8s/metrics/node/node_test.go
  • internal/k8s/metrics/node/option_test.go
  • internal/k8s/metrics/pod/option_test.go
  • internal/k8s/metrics/pod/pod_test.go
  • internal/k8s/node/node_test.go
  • internal/k8s/node/option_test.go
  • internal/k8s/option_test.go
  • internal/k8s/pod/option_test.go
  • internal/k8s/pod/pod_test.go
  • internal/k8s/reconciler_test.go
  • internal/log/format/format_test.go
  • internal/log/glg/glg_test.go
  • internal/log/level/level_test.go
  • internal/log/log_test.go
  • internal/log/logger/type_test.go
  • internal/log/mock/logger_test.go
  • internal/log/mock/retry_test.go
  • internal/log/retry/retry_test.go
  • internal/net/grpc/client_test.go
  • internal/net/grpc/grpcconns_test.go
  • internal/net/grpc/metric/client_test.go
  • internal/net/grpc/metric/server_test.go
  • internal/net/grpc/option_test.go
  • internal/net/grpc/pool/option_test.go
  • internal/net/grpc/pool/pool_test.go
  • internal/net/grpc/proto/proto_test.go
  • internal/net/grpc/status/status_test.go
  • internal/net/grpc/stream_test.go
  • internal/net/http/json/json_test.go
  • internal/net/http/middleware/timeout_test.go
  • internal/net/http/routing/router_test.go
  • internal/net/http/transport/roundtrip_test.go
  • internal/net/net_test.go
  • internal/net/tcp/control_darwin_test.go
  • internal/net/tcp/control_other_test.go
  • internal/net/tcp/control_unix_test.go
  • internal/net/tcp/control_windows_test.go
  • internal/net/tcp/dialer_test.go
  • internal/net/tcp/option_dialer_test.go
  • internal/observability/collector/collector_option_test.go
  • internal/observability/collector/collector_test.go
  • internal/observability/exporter/jaeger/jaeger_option_test.go
  • internal/observability/exporter/jaeger/jaeger_test.go
  • internal/observability/exporter/prometheus/prometheus_option_test.go
  • internal/observability/exporter/prometheus/prometheus_test.go
  • internal/observability/metrics/agent/ngt/ngt_test.go
  • internal/observability/metrics/manager/compressor/compressor_test.go
  • internal/observability/metrics/mem/mem_test.go
  • internal/observability/metrics/metrics_test.go
  • internal/observability/metrics/runtime/cgo/cgo_test.go
  • internal/observability/metrics/runtime/goroutine/goroutine_test.go
  • internal/observability/metrics/version/version_test.go
  • internal/observability/observability_option_test.go
  • internal/observability/observability_test.go
  • internal/observability/trace/status_test.go
  • internal/observability/trace/trace_option_test.go
  • internal/observability/trace/trace_test.go
  • internal/params/option_test.go
  • internal/params/params_test.go
  • internal/runner/option_test.go
  • internal/runner/runner_test.go
  • internal/servers/server/option_test.go
  • internal/servers/server/server_test.go
  • internal/servers/servers_test.go
  • internal/servers/starter/starter_test.go
  • internal/singleflight/singleflight_test.go
  • internal/tls/option_test.go
  • internal/tls/tls_test.go
  • internal/worker/queue_option_test.go
  • internal/worker/queue_test.go
  • internal/worker/worker_option_test.go
  • internal/worker/worker_test.go
  • pkg/agent/ngt/config/config_test.go
  • pkg/agent/ngt/handler/grpc/handler_test.go
  • pkg/agent/ngt/handler/grpc/option_test.go
  • pkg/agent/ngt/handler/rest/handler_test.go
  • pkg/agent/ngt/handler/rest/option_test.go
  • pkg/agent/ngt/router/option_test.go
  • pkg/agent/ngt/router/router_test.go
  • pkg/agent/ngt/service/kvs/kvs_test.go
  • pkg/agent/ngt/service/kvs/ou_test.go
  • pkg/agent/ngt/service/kvs/uo_test.go
  • pkg/agent/ngt/service/ngt_test.go
  • pkg/agent/ngt/service/vcaches_test.go
  • pkg/agent/ngt/usecase/agentd_test.go
  • pkg/discoverer/k8s/config/config_test.go
  • pkg/discoverer/k8s/handler/grpc/handler_test.go
  • pkg/discoverer/k8s/handler/grpc/option_test.go
  • pkg/discoverer/k8s/handler/rest/handler_test.go
  • pkg/discoverer/k8s/handler/rest/option_test.go
  • pkg/discoverer/k8s/router/option_test.go
  • pkg/discoverer/k8s/router/router_test.go
  • pkg/discoverer/k8s/service/discover_test.go
  • pkg/discoverer/k8s/service/nodemap_test.go
  • pkg/discoverer/k8s/service/nodemetricsmap_test.go
  • pkg/discoverer/k8s/service/option_test.go
  • pkg/discoverer/k8s/service/podmetricsmap_test.go
  • pkg/discoverer/k8s/service/podsmap_test.go
  • pkg/discoverer/k8s/usecase/discovered_test.go
  • pkg/gateway/vald/config/config_test.go
  • pkg/gateway/vald/handler/grpc/checklist_test.go
  • pkg/gateway/vald/handler/grpc/handler_test.go
  • pkg/gateway/vald/handler/grpc/option_test.go
  • pkg/gateway/vald/handler/rest/handler_test.go
  • pkg/gateway/vald/handler/rest/option_test.go
  • pkg/gateway/vald/router/option_test.go
  • pkg/gateway/vald/router/router_test.go
  • pkg/gateway/vald/service/backup_option_test.go
  • pkg/gateway/vald/service/backup_test.go
  • pkg/gateway/vald/service/filter_option_test.go
  • pkg/gateway/vald/service/filter_test.go
  • pkg/gateway/vald/service/gateway_option_test.go
  • pkg/gateway/vald/service/gateway_test.go
  • pkg/gateway/vald/service/meta_option_test.go
  • pkg/gateway/vald/service/meta_test.go
  • pkg/gateway/vald/usecase/vald_test.go
  • pkg/manager/backup/cassandra/config/config_test.go
  • pkg/manager/backup/cassandra/handler/grpc/handler_test.go
  • pkg/manager/backup/cassandra/handler/grpc/option_test.go
  • pkg/manager/backup/cassandra/handler/rest/handler_test.go
  • pkg/manager/backup/cassandra/handler/rest/option_test.go
  • pkg/manager/backup/cassandra/router/option_test.go
  • pkg/manager/backup/cassandra/router/router_test.go
  • pkg/manager/backup/cassandra/service/cassandra_test.go
  • pkg/manager/backup/cassandra/usecase/backupd_test.go
  • pkg/manager/backup/mysql/config/config_test.go
  • pkg/manager/backup/mysql/handler/grpc/handler_test.go
  • pkg/manager/backup/mysql/handler/grpc/option_test.go
  • pkg/manager/backup/mysql/handler/rest/handler_test.go
  • pkg/manager/backup/mysql/handler/rest/option_test.go
  • pkg/manager/backup/mysql/model/model_test.go
  • pkg/manager/backup/mysql/router/option_test.go
  • pkg/manager/backup/mysql/router/router_test.go
  • pkg/manager/backup/mysql/service/mysql_test.go
  • pkg/manager/backup/mysql/usecase/backupd_test.go
  • pkg/manager/compressor/config/config_test.go
  • pkg/manager/compressor/handler/grpc/handler_test.go
  • pkg/manager/compressor/handler/grpc/option_test.go
  • pkg/manager/compressor/handler/rest/handler_test.go
  • pkg/manager/compressor/handler/rest/option_test.go
  • pkg/manager/compressor/router/option_test.go
  • pkg/manager/compressor/router/router_test.go
  • pkg/manager/compressor/service/backup_option_test.go
  • pkg/manager/compressor/service/backup_test.go
  • pkg/manager/compressor/service/compress_option_test.go
  • pkg/manager/compressor/service/compress_test.go
  • pkg/manager/compressor/service/registerer_option_test.go
  • pkg/manager/compressor/service/registerer_test.go
  • pkg/manager/compressor/usecase/compressord_test.go
  • pkg/manager/index/config/config_test.go
  • pkg/manager/index/handler/grpc/checklist_test.go
  • pkg/manager/index/handler/grpc/handler_test.go
  • pkg/manager/index/handler/grpc/option_test.go
  • pkg/manager/index/handler/rest/handler_test.go
  • pkg/manager/index/handler/rest/option_test.go
  • pkg/manager/index/router/option_test.go
  • pkg/manager/index/router/router_test.go
  • pkg/manager/index/service/indexer_test.go
  • pkg/manager/index/service/indexinfos_test.go
  • pkg/manager/index/service/option_test.go
  • pkg/manager/index/usecase/indexer_test.go
  • pkg/manager/replication/agent/config/config_test.go
  • pkg/manager/replication/agent/handler/grpc/handler_test.go
  • pkg/manager/replication/agent/handler/rest/handler_test.go
  • pkg/manager/replication/agent/handler/rest/option_test.go
  • pkg/manager/replication/agent/router/option_test.go
  • pkg/manager/replication/agent/router/router_test.go
  • pkg/manager/replication/agent/usecase/backupd_test.go
  • pkg/manager/replication/controller/config/config_test.go
  • pkg/manager/replication/controller/handler/grpc/handler_test.go
  • pkg/manager/replication/controller/handler/grpc/option_test.go
  • pkg/manager/replication/controller/handler/rest/handler_test.go
  • pkg/manager/replication/controller/handler/rest/option_test.go
  • pkg/manager/replication/controller/router/option_test.go
  • pkg/manager/replication/controller/router/router_test.go
  • pkg/manager/replication/controller/service/discover_test.go
  • pkg/manager/replication/controller/service/nodemap_test.go
  • pkg/manager/replication/controller/service/nodemetricsmap_test.go
  • pkg/manager/replication/controller/service/option_test.go
  • pkg/manager/replication/controller/service/podmetricsmap_test.go
  • pkg/manager/replication/controller/service/podsmap_test.go
  • pkg/manager/replication/controller/usecase/discovered_test.go
  • pkg/meta/cassandra/config/config_test.go
  • pkg/meta/cassandra/handler/grpc/handler_test.go
  • pkg/meta/cassandra/handler/grpc/option_test.go
  • pkg/meta/cassandra/handler/rest/handler_test.go
  • pkg/meta/cassandra/handler/rest/option_test.go
  • pkg/meta/cassandra/router/option_test.go
  • pkg/meta/cassandra/router/router_test.go
  • pkg/meta/cassandra/service/cassandra_test.go
  • pkg/meta/cassandra/usecase/meta_test.go
  • pkg/meta/redis/config/config_test.go
  • pkg/meta/redis/handler/grpc/handler_test.go
  • pkg/meta/redis/handler/grpc/option_test.go
  • pkg/meta/redis/handler/rest/handler_test.go
  • pkg/meta/redis/handler/rest/option_test.go
  • pkg/meta/redis/router/option_test.go
  • pkg/meta/redis/router/router_test.go
  • pkg/meta/redis/service/redis_test.go
  • pkg/meta/redis/usecase/meta_test.go

Related Issue:

close #325

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

vankichi and others added 30 commits April 24, 2020 02:21
@vankichi @actions-user
✅ generete missing test file
24e4ec5 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @actions-user
⏪ remove unnecessary test files
c25e37d 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @actions-user
✅ added missing new test code
8c80e94 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @actions-user
🔧 added make gentest for missing test code
da8ecba 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @actions-user
🔥 removing files
9130963 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@hlts2 @actions-user
feat: add template file
fa6510b 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
refactor: adjust space
41db3a1 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
refactor: definition position
4807044 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: function test case type
d980f9e 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vankichi @actions-user
✅ generete missing test file
3725095 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @actions-user
⏪ remove unnecessary test files
0a3a9f7 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @actions-user
✅ added missing new test code
13de49b 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @actions-user
🔥 removing files
f3bbc3d 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@hlts2 @actions-user
feat: add template file
4d53b90 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
refactor: adjust space
6bde178 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
refactor: definition position
4f373b7 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@kevindiu @actions-user
draft gen-option-test
18d32d2
@hlts2 @actions-user
refactor: benchmark script
dd1e3dd 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: add option
ebbf0a1 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: add fill type
c80f04f 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: add message
e1bcc1f 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: add message
9179ac3 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: bug params name
b787d82 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: bug of args parameter
0a0ec92 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: commentout test case
c8c8814 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: test template
6c100d9 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vankichi
✅ generate missing test files
9ed2925 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi
✅ fix test
dee132c 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi
✅ fix test
1c5af84 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi
Merge branch 'master' into test/cmd-hack-internal-pkg/create-test-ori…
7e0ce5b 
…ginal-template
@pull-assistant
Copy link

pull-assistant bot commented Apr 24, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan (4 warnings)

     ✅ generete missing test file

     ✅ generete missing test file

     ⏪ remove unnecessary test files

     ⏪ remove unnecessary test files

     ✅ added missing new test code

     ✅ added missing new test code

🔧 added make gentest for missing test code

Makefile.d/functions.mk 50% changes removed in draft gen-option-tes...

     🔥 removing files

     🔥 removing files

     feat: add template file

feat: add template file

...templates/common/function.tmpl 89% changes removed in refactor: adjust spa...

     refactor: adjust space

     refactor: adjust space

refactor: definition position

...templates/common/function.tmpl 50% changes removed in refactor: definition...

     refactor: definition position

     feat: function test case type

     draft gen-option-test

     refactor: benchmark script

     feat: add option

     fix: add fill type

     fix: add message

     fix: add message

fix: bug params name

...templates/common/function.tmpl 50% changes removed in fix: test template

     fix: bug of args parameter

     fix: commentout test case

     fix: test template

     ✅ generate missing test files

     ✅ fix test

     ✅ fix test

     Merge branch 'master' into test/cmd-hack-internal-pkg/create-test-orig...

     fix: go.mod/go.sum

     📝 fix

     📝 fix

Powered by Pull Assistant. Last update 24e4ec5 ... a6e1b7c. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vankichi
fix: go.mod/go.sum
7e2ce70 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@codecov
Copy link

codecov bot commented Apr 24, 2020 •
edited
Loading

Codecov Report

Merging #348 into master will decrease coverage by 62.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #348       +/-   ##
==========================================
- Coverage   70.79%   8.02%   -62.78%     
==========================================
  Files          41     341      +300     
  Lines        1839   17904    +16065     
==========================================
+ Hits         1302    1437      +135     
- Misses        472   16268    +15796     
- Partials       65     199      +134
Impacted Files Coverage Δ
hack/license/gen/main.go 0.00% <ø> (ø)
pkg/manager/index/handler/rest/handler.go 0.00% <0.00%> (ø)
hack/tools/metrics/main.go 0.00% <0.00%> (ø)
pkg/manager/compressor/handler/rest/handler.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/service/discover.go 0.00% <0.00%> (ø)
.../manager/replication/agent/handler/rest/handler.go 0.00% <0.00%> (ø)
hack/benchmark/internal/core/gongt/option.go 17.64% <0.00%> (ø)
pkg/meta/cassandra/router/option.go 11.11% <0.00%> (ø)
internal/config/transport.go 0.00% <0.00%> (ø)
pkg/manager/backup/mysql/handler/grpc/option.go 0.00% <0.00%> (ø)
... and 291 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e1b7c...a6e1b7c. Read the comment docs.

@vankichi vankichi changed the title Test/cmd hack internal pkg/create test original template create missing test files by the our original test template Apr 24, 2020
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vankichi
📝 fix
0e2ee14 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the test/cmd-hack-internal-pkg/create-test-original-template branch from e6031bc to 0e2ee14 Compare April 24, 2020 06:23
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vankichi vankichi marked this pull request as ready for review April 24, 2020 06:24
@vankichi
📝 fix
a6e1b7c 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango merged commit 5619b91 into master Apr 24, 2020
@kpango kpango deleted the test/cmd-hack-internal-pkg/create-test-original-template branch April 24, 2020 06:32
@vdaas-ci
Copy link
Collaborator

[REBASE] Failed to rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/agent area/discoverer area/gateway area/manager/backup area/manager/index area/manager/replication area/meta priority/low size/XXXL team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[proposal] Test code of the testing guideline
5 participants
@vankichi @vdaas-ci @kpango @hlts2 @kevindiu