Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Fix conflicts between formatter and helm template #350

Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Apr 27, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Fix conflicts between formatter and Helm template.

Related Issue:

Not an issue but there's a card in SRE task board.

How Has This Been Tested?:

Nothing.

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Apr 27, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     💚 Fix conflicts between formatter and helm template

     🤖 Update license headers and formatting go codes

Powered by Pull Assistant. Last update 0d5e90c ... e71c566. Read the comment docs.

@kpango
Copy link
Collaborator

kpango commented Apr 27, 2020

/rebase
/format

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: ci/helm-k8s/fix-conflict-between-formatter-and-helm-template

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the ci/helm-k8s/fix-conflict-between-formatter-and-helm-template branch from 3e151a7 to 0d5e90c Compare April 27, 2020 02:24
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

Signed-off-by: vdaas-ci <ci@vdaas.org>
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit e40447f into master Apr 27, 2020
@kpango kpango deleted the ci/helm-k8s/fix-conflict-between-formatter-and-helm-template branch April 27, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants