Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 update helm docs when version is published #355

Merged
merged 3 commits into from
Apr 28, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Apr 28, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Currently, the Helm docs are updated after the version is updated.
So, updated docs are not included in the release.
In this PR, the release flow is revised to include these updates.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Apr 28, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     💚 update helm docs when version is published

     📝 Add twitter badge

     Update README.md

Powered by Pull Assistant. Last update ee35d4c ... f81a4ce. Read the comment docs.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit a77af37 into master Apr 28, 2020
@kpango kpango deleted the ci/release/update-helm-docs-when-version-published branch April 28, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants