Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add goleak #359

Merged
merged 1 commit into from
May 1, 2020
Merged

add goleak #359

merged 1 commit into from
May 1, 2020

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Apr 30, 2020

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

add goleak

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Apr 30, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     add goleak

Powered by Pull Assistant. Last update 754e84e ... 754e84e. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango
Copy link
Collaborator Author

kpango commented Apr 30, 2020

/rebase
/format

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: refactor/test/add-goleak

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #359 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #359      +/-   ##
=========================================
- Coverage    8.10%   7.99%   -0.12%     
=========================================
  Files         327     345      +18     
  Lines       17731   17733       +2     
=========================================
- Hits         1437    1417      -20     
- Misses      16094   16137      +43     
+ Partials      200     179      -21     
Impacted Files Coverage Δ
hack/benchmark/core/benchmark/strategy/strategy.go 0.00% <ø> (ø)
hack/benchmark/internal/core/gongt/gongt.go 0.00% <ø> (ø)
internal/singleflight/singleflight.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/handler/grpc/handler.go 0.00% <0.00%> (ø)
internal/db/nosql/cassandra/option.go
internal/db/nosql/cassandra/cassandra.go
internal/db/nosql/cassandra/conviction.go
pkg/tools/cli/loadtest/usecase/load.go 0.00% <0.00%> (ø)
internal/errors/mysql.go 0.00% <0.00%> (ø)
internal/k8s/metrics/pod/pod.go 0.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2dce9...754e84e. Read the comment docs.

@kpango kpango force-pushed the refactor/test/add-goleak branch from 0dac046 to 068e47d Compare May 1, 2020 02:44
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango force-pushed the refactor/test/add-goleak branch from 068e47d to 193fbdf Compare May 1, 2020 02:44
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango
Copy link
Collaborator Author

kpango commented May 1, 2020

/rebase
/format

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[REBASE] Rebase triggered by kpango for branch: refactor/test/add-goleak

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

go.mod Outdated
@@ -45,6 +45,7 @@ require (
github.com/kpango/glg v1.5.1
github.com/lucasb-eyer/go-colorful v1.0.3
github.com/pierrec/lz4/v3 v3.3.2
github.com/pkg/errors v0.8.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not understand why this package is added into go.mod...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not realize this. thx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vankichi no, I think I made an mistake... seems it is not caused by the checkfunc...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it is no longer exists now, so it should be ok~

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango force-pushed the refactor/test/add-goleak branch from 54321ae to 4c750ae Compare May 1, 2020 02:57
@vankichi
Copy link
Contributor

vankichi commented May 1, 2020

/approve
/format
/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

vankichi
vankichi previously approved these changes May 1, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[REBASE] Rebase triggered by vankichi for branch: refactor/test/add-goleak

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@kpango kpango merged commit 01847a6 into master May 1, 2020
@kpango kpango deleted the refactor/test/add-goleak branch May 1, 2020 03:05
@vankichi
Copy link
Contributor

vankichi commented May 7, 2020

close #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants