-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add goleak #359
add goleak #359
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
[WARNING] Changes in |
/rebase |
[REBASE] Rebase triggered by kpango for branch: refactor/test/add-goleak |
d3c18bb
to
0dac046
Compare
[WARNING] Changes in |
[FORMAT] Updating license headers and formatting go codes triggered by kpango. |
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=========================================
- Coverage 8.10% 7.99% -0.12%
=========================================
Files 327 345 +18
Lines 17731 17733 +2
=========================================
- Hits 1437 1417 -20
- Misses 16094 16137 +43
+ Partials 200 179 -21
Continue to review full report at Codecov.
|
0dac046
to
068e47d
Compare
[WARNING] Changes in |
068e47d
to
193fbdf
Compare
[WARNING] Changes in |
/rebase |
[REBASE] Rebase triggered by kpango for branch: refactor/test/add-goleak |
193fbdf
to
c1aab1c
Compare
[WARNING] Changes in |
[FORMAT] Updating license headers and formatting go codes triggered by kpango. |
go.mod
Outdated
@@ -45,6 +45,7 @@ require ( | |||
github.com/kpango/glg v1.5.1 | |||
github.com/lucasb-eyer/go-colorful v1.0.3 | |||
github.com/pierrec/lz4/v3 v3.3.2 | |||
github.com/pkg/errors v0.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not understand why this package is added into go.mod
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not realize this. thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vankichi no, I think I made an mistake... seems it is not caused by the checkfunc
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it is no longer exists now, so it should be ok~
[WARNING] Changes in |
54321ae
to
4c750ae
Compare
/approve |
[WARNING] Changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REBASE] Rebase triggered by vankichi for branch: refactor/test/add-goleak |
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
4c750ae
to
754e84e
Compare
[WARNING] Changes in |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
close #351 |
Signed-off-by: kpango i.can.feel.gravity@gmail.com
Description:
add goleak
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: