-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change fmt.Errorf to errors.Errorf #361
Conversation
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Best reviewed: commit by commit
Optimal code review plan
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for correcting my mistake. 🙏
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=========================================
- Coverage 7.99% 7.94% -0.06%
=========================================
Files 345 345
Lines 17733 17733
=========================================
- Hits 1417 1408 -9
- Misses 16137 16144 +7
- Partials 179 181 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
/approve |
[REBASE] Rebase triggered by vankichi for branch: refactor/test/change-errorf-package |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
Signed-off-by: vdaas-ci <ci@vdaas.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Signed-off-by: kpango i.can.feel.gravity@gmail.com
Description:
replace fmt.Errorf to errors.Errorf
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: