Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vald contacts document #373

Merged
merged 23 commits into from
May 21, 2020
Merged

Vald contacts document #373

merged 23 commits into from
May 21, 2020

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented May 13, 2020 •
edited
Loading

Description:

This PR create a Vald contact document.
I added documentation so that other people can contact us via slack or email.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented May 13, 2020 •
edited
Loading

Score: 0.50

Best reviewed: commit by commit

Optimal code review plan (7 warnings, 2 commits squashed)

feat: added report.md

docs/user/report.md 81% changes removed in feat: apply suggesti...

     fix: markdown indent

feat: added new sent... ... fix: type and add ne...

Squashed 2 commits:

docs/user/report.md 43% changes removed in feat: apply suggesti...

     fix: type

feat: add link

docs/user/report.md 60% changes removed in fix: file name

     fix: delete link

     fix: delete unnecessary file

     fix: added link

fix: file name

docs/user/contacts.md 67% changes removed in feat: apply suggesti...

fix: apply the suggestion from review

docs/user/contacts.md 56% changes removed in feat: apply suggesti...

     fix: apply the suggestion from review

     feat: apply suggestion of set-team

     feat: apply suggestion of set-team

feat: apply suggestion

docs/user/contacts.md 83% changes removed in feat: apply suggesti...

     feat: apply suggestion

feat: apply suggestion

docs/user/contacts.md 60% changes removed in fix: apply suggestio...

     feat: add link

     feat: apply suggestion

     feat: apply suggestion

     fix: apply suggestion

     fix: apply sugestion

     fix: apply suggestion

Powered by Pull Assistant. Last update 50115a2 ... 6aeb467. Read the comment docs.

@hlts2
Copy link
Collaborator Author

hlts2 commented May 13, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: documentation/report_doc

@hlts2
Copy link
Collaborator Author

hlts2 commented May 13, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: documentation/report_doc

@hlts2 hlts2 changed the title [Draft] Vald report document [Draft] Vald contacts document May 13, 2020
@hlts2
Copy link
Collaborator Author

hlts2 commented May 13, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: documentation/report_doc

vankichi
vankichi reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hlts2
Could you add TOC at top of the this document?

docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
@hlts2
Copy link
Collaborator Author

hlts2 commented May 14, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: documentation/report_doc

kevindiu
kevindiu reviewed May 14, 2020
View reviewed changes
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
@hlts2
Copy link
Collaborator Author

hlts2 commented May 14, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: documentation/report_doc

kevindiu
kevindiu reviewed May 14, 2020
View reviewed changes
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
@kevindiu
Copy link
Contributor

LGTM

vankichi
vankichi reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hlts2
I leave some comments.
And, why you delete the link of the issue?
we should show cuz user cannot find out.
you can add the link each section, for example please submit [here]().
please think deeply about the text for guide issue links 🙏

docs/user/contacts.md Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
docs/user/contacts.md Outdated Show resolved Hide resolved
kevindiu
kevindiu reviewed May 14, 2020
View reviewed changes
docs/user/contacts.md Outdated Show resolved Hide resolved
kevindiu
kevindiu reviewed May 14, 2020
View reviewed changes
docs/user/contacts.md Outdated Show resolved Hide resolved
@hlts2
Copy link
Collaborator Author

hlts2 commented May 18, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: documentation/report_doc

@hlts2
Copy link
Collaborator Author

hlts2 commented May 19, 2020

/rebase

@hlts2
Copy link
Collaborator Author

hlts2 commented May 21, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: documentation/report_doc

hlts2 added 23 commits May 21, 2020 03:38
@hlts2 @actions-user
feat: added report.md
50115a2 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: markdown indent
70a3d45 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: added new sentence
c0dd588 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: type and add new line
48f96d4 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: type
e5581af 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: add link
050d573 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: delete link
537acd4 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: delete unnecessary file
49eaf6e 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: added link
fcf0ba3 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: file name
aa3e5b6 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply the suggestion from review
19922fa 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply the suggestion from review
ac9a64b 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: apply suggestion of set-team
270a490 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: apply suggestion of set-team
014215c 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: apply suggestion
ed0e681 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: apply suggestion
600ddeb 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: apply suggestion
157b10a 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: add link
5c77aab 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: apply suggestion
48d428c 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: apply suggestion
2ef4250 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply suggestion
aad70aa 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply sugestion
e9db588 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply suggestion
6aeb467 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot added size/S and removed size/S labels May 21, 2020
@kpango kpango merged commit 682b3a2 into master May 21, 2020
@kpango kpango deleted the documentation/report_doc branch May 21, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindiu kevindiu kevindiu left review comments

@vankichi vankichi vankichi left review comments

@kmrmt kmrmt Awaiting requested review from kmrmt

@kpango kpango Awaiting requested review from kpango

@rinx rinx Awaiting requested review from rinx

Assignees
No one assigned
Labels
priority/low size/M status/author-review team/sre SRE team type/ci type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hlts2 @vdaas-ci @kevindiu @vankichi @kpango