tensorflow test #378

datelier · 2020-05-14T05:03:34Z

Description:

test tensorflow package.

Related Issue:

How Has This Been Tested?:

Environment:

Golang Version: 1.14
Docker Version: 19.03.5
Kubernetes Version: 1.17.3
NGT Version: 1.9.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-05-14T05:03:36Z

Best reviewed: commit by commit

Optimal code review plan (2 warnings)

Add tensorflow test code

.../tensorflow/tensorflow_test.go 44% changes removed in gofmt

Add tensorflow option test code

fix test name

fix DeepSource issue: Empty string test can be improved

fix Deepsource issue: Incomplete condition detected

remove sessionTarget, sessionConfig

fix DeepSource issue: Empty string test can be improved

fix test case based on review

gofmt

...erter/tensorflow/tensorflow.go 44% changes removed in delete Closer interf...

fix golangci-lint issue

delete Closer interface

fix DeepSource issue: Function literal can be simplified

Merge branch 'master' into test/internal/tensorflow

Powered by Pull Assistant. Last update 3d57c14 ... 001fba7. Read the comment docs.

codecov · 2020-05-14T05:10:08Z

Codecov Report

Merging #378 into master will increase coverage by 0.94%.
The diff coverage is 86.95%.

@@            Coverage Diff            @@
##           master    #378      +/-   ##
=========================================
+ Coverage    7.35%   8.29%   +0.94%     
=========================================
  Files         383     372      -11     
  Lines       19664   18847     -817     
=========================================
+ Hits         1446    1564     +118     
+ Misses      17999   17068     -931     
+ Partials      219     215       -4

Impacted Files	Coverage Δ
internal/core/converter/tensorflow/option.go	`96.49% <85.71%> (+90.24%)`	⬆️
internal/core/converter/tensorflow/tensorflow.go	`87.87% <88.88%> (+87.87%)`	⬆️
internal/db/storage/blob/s3/option.go	`0.00% <0.00%> (-6.67%)`	⬇️
internal/config/sidecar.go	`0.00% <0.00%> (ø)`
internal/config/compress.go	`0.00% <0.00%> (ø)`
internal/file/watch/watch.go	`0.00% <0.00%> (ø)`
internal/file/watch/option.go	`0.00% <0.00%> (ø)`
internal/db/storage/blob/s3/s3.go	`0.00% <0.00%> (ø)`
pkg/agent/sidecar/config/config.go	`0.00% <0.00%> (ø)`
pkg/agent/sidecar/usecase/sidecard.go	`0.00% <0.00%> (ø)`
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e92aa...001fba7. Read the comment docs.

hlts2 · 2020-05-14T08:05:10Z

internal/core/converter/tensorflow/option_test.go

+			},
+		},
+		{
+			name: "set value",


Suggested change

name: "set value",

name: "set success when opts is not nil",

hlts2 · 2020-05-14T08:05:21Z

internal/core/converter/tensorflow/option_test.go

+		{
+			name: "set value",
+			args: args{
+				opts: &SessionOptions{},


Suggested change

opts: &SessionOptions{},

opts: new(SessionOptions),

hlts2 · 2020-05-14T08:05:37Z

internal/core/converter/tensorflow/option_test.go

+			},
+			want: want{
+				obj: &T{
+					options: &SessionOptions{},


Suggested change

options: &SessionOptions{},

options: new(SessionOptions),

hlts2 · 2020-05-14T08:06:26Z

internal/core/converter/tensorflow/option_test.go

-		   }(),
-		*/
+		{
+			name: "set default",


Suggested change

name: "set default",

name: "set nothing when tgt is empty",

hlts2 · 2020-05-14T08:08:02Z

internal/core/converter/tensorflow/option_test.go

-		*/
+		{
+			name: "set default",
+			args: args{


if you want to set empty or nil object, you can delete args field.

args: args { tgt: "" } ↑ you can delete `args` fields

hlts2 · 2020-05-18T09:53:13Z

internal/core/converter/tensorflow/tensorflow_test.go

-		   }(),
-		*/
+		{
+			name: "return (value, nil)",


Suggested change

name: "return (value, nil)",

name: "returns (value, nil) when run function returns nil",

hlts2 · 2020-05-18T09:53:55Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "run() error",


Suggested change

name: "run() error",

name: "returns (nil, error) when run function returns `session.Run() error`",

hlts2 · 2020-05-18T09:57:12Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "nil tensor error: run() return nil",


Suggested change

name: "nil tensor error: run() return nil",

name: "returns (nil, error) when

tensors returned by the run function is nil",

hlts2 · 2020-05-18T09:57:35Z

internal/core/converter/tensorflow/tensorflow_test.go

+		},
+		{
+			name: "nil tensor error: run() return nil",
+			args: args{


Could you please delete this field.

hlts2 · 2020-05-18T09:58:29Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "nil tensor error: run() return [nil]",


Suggested change

name: "nil tensor error: run() return [nil]",

name: "returns (nil, error) when

element of tensors returned by the run function is nil",

hlts2 · 2020-05-19T02:07:26Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "nil tensor error: run() return nil",


Suggested change

name: "nil tensor error: run() return nil",

name: "returns (nil, error) when

tensors returned by the run function is nil",

hlts2 · 2020-05-19T02:07:59Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "nil tensor error: run() return [nil]",


Suggested change

name: "nil tensor error: run() return [nil]",

name: "returns (nil, error) when

element of tensors returned by the run function is nil",

hlts2 · 2020-05-19T02:10:54Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "failed to cast error: ndim == TwoDim",


Suggested change

name: "failed to cast error: ndim == TwoDim",

name: "returns (nil, error) when ndim is `TwoDim` and returns error of `ErrFailedToCastTF",

hlts2 · 2020-05-19T02:12:44Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "failed to cast error: ndim == ThreeDim",


Suggested change

name: "failed to cast error: ndim == ThreeDim",

name: "returns (nil, error) when ndim is `ThreeDim ` and returns error of`ErrFailedToCastTF`",

hlts2 · 2020-05-19T02:13:26Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "failed to cast error: ndim == default",


Suggested change

name: "failed to cast error: ndim == default",

name: "returns (nil, error) when ndim is `default ` and returns error of`ErrFailedToCastTF`",

hlts2 · 2020-05-19T02:19:00Z

internal/core/converter/tensorflow/tensorflow_test.go

-		*/
+		{
+			name: "return ([], nil): inputs == nil",
+			args: args{


you can delete this field.

hlts2 · 2020-05-19T02:19:41Z

internal/core/converter/tensorflow/tensorflow_test.go

-		   }(),
-		*/
+		{
+			name: "return ([], nil): inputs == nil",


Suggested change

name: "return ([], nil): inputs == nil",

name: "return ([], nil) when inputs is nil and Run function returns ([], nil)",

hlts2 · 2020-05-19T02:23:01Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "length error",


Suggested change

name: "length error",

name: "returns (nil, error) when length of inputs and feeds field are different",

hlts2 · 2020-05-19T02:26:06Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "session.Run() error",


Suggested change

name: "session.Run() error",

name: "returns (nil, error) when Run function returns error",

hlts2 · 2020-05-19T02:27:55Z

internal/core/converter/tensorflow/tensorflow_test.go

+			checkFunc: defaultCheckFunc,
+		},
+		{
+			name: "return ([], nil): inputs == {\"test\"}",


Suggested change

name: "return ([], nil): inputs == {\"test\"}",

name: "return ([], nil) when inputs is `{"test"} and Run function returns ([], nil)`",

hlts2 · 2020-05-19T02:30:25Z

internal/core/converter/tensorflow/tensorflow_test.go

+				},
+				err: nil,
+			},
+			checkFunc: defaultCheckFunc,


you can delete this line, because this function was set automatically in the tt.Run.

datelier · 2020-05-20T06:47:41Z

/rebase

rinx · 2020-05-20T06:50:53Z

/rebase

vdaas-ci · 2020-05-20T06:51:26Z

[REBASE] Rebase triggered by rinx for branch: test/internal/tensorflow

internal/core/converter/tensorflow/tensorflow.go

github-actions · 2020-05-20T07:01:05Z

internal/core/converter/tensorflow/tensorflow_mock_test.go

+	CloseFunc func() error
+}
+
+func (m *mockSession) Run(feeds map[tf.Output]*tf.Tensor, fetches []tf.Output, operations []*Operation) ([]*tf.Tensor, error) {


[golangci] _{reported by reviewdog 🐶}
line is 127 characters (lll)

github-actions · 2020-05-20T07:01:05Z

internal/core/converter/tensorflow/tensorflow_test.go

+				options:       nil,
+				graph:         nil,
+				session: &mockSession{
+					RunFunc: func(feeds map[tf.Output]*tf.Tensor, fetches []tf.Output, operations []*tf.Operation) ([]*tf.Tensor, error) {


[golangci] _{reported by reviewdog 🐶}
line is 123 characters (lll)

github-actions · 2020-05-20T07:01:05Z

internal/core/converter/tensorflow/tensorflow_test.go

+				options:       nil,
+				graph:         tf.NewGraph(),
+				session: &mockSession{
+					RunFunc: func(feeds map[tf.Output]*tf.Tensor, fetches []tf.Output, operations []*tf.Operation) ([]*tf.Tensor, error) {


[golangci] _{reported by reviewdog 🐶}
line is 123 characters (lll)

github-actions · 2020-05-20T07:01:05Z

internal/core/converter/tensorflow/tensorflow_test.go

+				options:       nil,
+				graph:         tf.NewGraph(),
+				session: &mockSession{
+					RunFunc: func(feeds map[tf.Output]*tf.Tensor, fetches []tf.Output, operations []*tf.Operation) ([]*tf.Tensor, error) {


[golangci] _{reported by reviewdog 🐶}
line is 123 characters (lll)

github-actions · 2020-05-20T07:01:05Z

internal/core/converter/tensorflow/tensorflow.go

@@ -56,20 +63,17 @@ const (
 	ThreeDim
 )

+var loadFunc = func(exportDir string, tags []string, options *SessionOptions) (*tf.SavedModel, error) {


[golangci] _{reported by reviewdog 🐶}
loadFunc is a global variable (gochecknoglobals)

github-actions · 2020-05-20T07:01:06Z

internal/core/converter/tensorflow/option_test.go

+			want: want{
+				obj: &T{
+					feeds: []OutputSpec{
+						OutputSpec{


[golangci] _{reported by reviewdog 🐶}
File is not gofmt-ed with -s (gofmt)

@datelier
Could you please format this file?

github-actions · 2020-05-20T07:01:06Z

internal/core/converter/tensorflow/tensorflow_test.go

+				exportDir: "",
+				tags:      nil,
+				feeds: []OutputSpec{
+					OutputSpec{


[golangci] _{reported by reviewdog 🐶}
File is not gofmt-ed with -s (gofmt)

#378 (comment)

github-actions · 2020-05-20T07:01:06Z

internal/core/converter/tensorflow/tensorflow.go

@@ -109,7 +113,7 @@ func (t *tensorflow) GetVector(inputs ...string) ([]float64, error) {
 	if err != nil {
 		return nil, err
 	}
-	if tensors == nil || tensors[0] == nil || tensors[0].Value() == nil {
+	if len(tensors) == 0 || tensors[0] == nil || tensors[0].Value() == nil {


[golangci] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments (wsl)

github-actions · 2020-05-20T07:01:06Z

internal/core/converter/tensorflow/tensorflow.go

@@ -149,7 +153,7 @@ func (t *tensorflow) GetValue(inputs ...string) (interface{}, error) {
 	if err != nil {
 		return nil, err
 	}
-	if tensors == nil || tensors[0] == nil {
+	if len(tensors) == 0 || tensors[0] == nil {


[golangci] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments (wsl)

kevindiu · 2020-05-20T05:31:35Z

internal/core/converter/tensorflow/tensorflow.go

 func New(opts ...Option) (TF, error) {
 	t := new(tensorflow)
 	for _, opt := range append(defaultOpts, opts...) {
 		opt(t)
 	}

-	if t.options == nil && (len(t.sessionTarget) != 0 || t.sessionConfig != nil) {
+	if t.options == nil && (t.sessionTarget == "" || t.sessionConfig != nil) {


we don't need nil checking for the string.
you can try on https://play.golang.org/p/_9aagB_YbOM

Suggested change

if t.options == nil && (t.sessionTarget == "" || t.sessionConfig != nil) {

if t.options == nil && t.sessionTarget == "" {

internal/core/converter/tensorflow/tensorflow.go

kevindiu · 2020-05-20T07:25:34Z

After I run the go test command, the following error occurred.

% go test ./...
go: downloading github.com/cockroachdb/errors v1.2.5-0.20200508151722-0daaf51d1ebe
go: downloading github.com/cockroachdb/sentry-go v0.3.999
# github.com/tensorflow/tensorflow/tensorflow/go
ld: library not found for -ltensorflow
clang: error: linker command failed with exit code 1 (use -v to see invocation)
FAIL	github.com/vdaas/vald/internal/core/converter/tensorflow [build failed]
FAIL

after searching on google i found this link:
https://qiita.com/ysuzuki19/items/044a85efb03f3c290a95

do we need to install the tool before running the go test?

datelier · 2020-05-21T05:06:13Z

@kevindiu
Did you install "TensorFlow C library" before running the go test?
We need to install "TensorFlow C library", so please install this library or do make tensorflow/install.
https://www.tensorflow.org/install/lang_go

hlts2 · 2020-05-25T01:42:31Z

internal/core/converter/tensorflow/option.go

-		if len(tgt) != 0 {
-			t.sessionTarget = tgt
+		if tgt != "" {
+			if t.options == nil {


I think it's good! 👍

datelier · 2020-05-25T05:37:08Z

/rebase

vdaas-ci · 2020-05-25T05:37:44Z

[REBASE] Rebase triggered by datelier for branch: test/internal/tensorflow

github-actions · 2020-05-25T05:43:50Z

internal/core/converter/tensorflow/tensorflow.go

@@ -56,25 +63,25 @@ const (
 	ThreeDim
 )

+var loadFunc = func(exportDir string, tags []string, options *SessionOptions) (*tf.SavedModel, error) {


[golangci] _{reported by reviewdog 🐶}
unlambda: replace `func(exportDir string, tags []string, options *SessionOptions) (*tf.SavedModel, error) {

kevindiu · 2020-05-25T07:18:58Z

@kevindiu
Did you install "TensorFlow C library" before running the go test?
We need to install "TensorFlow C library", so please install this library or do make tensorflow/install.
https://www.tensorflow.org/install/lang_go

I tried to install it but it is failed....

% make tensorflow/install
curl -LO https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-linux-x86_64-1.15.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 56.3M  100 56.3M    0     0  12.6M      0  0:00:04  0:00:04 --:--:-- 12.8M
tar -C /usr/local -xzf libtensorflow-cpu-linux-x86_64-1.15.0.tar.gz
./: Can't restore time
./THIRD_PARTY_TF_C_LICENSES: Can't create 'THIRD_PARTY_TF_C_LICENSES'
./LICENSE: Can't create 'LICENSE'
tar: Error exit delayed from previous errors.
make: *** [/usr/local/lib/libtensorflow.so] Error 1

kevindiu · 2020-05-25T07:41:40Z

Seems the make command is not supported on Mac, I installed the libtensorflow using brew install libtensorflow command and it works. thank you :)

vankichi · 2020-06-02T01:48:12Z

/rebase

vdaas-ci · 2020-06-02T01:48:49Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/tensorflow

vdaas-ci · 2020-06-02T01:48:54Z

[REBASE] Failed to rebase.

Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>

kevindiu · 2020-06-02T10:09:37Z

LGTMed other than https://github.com/vdaas/vald/pull/378/files#r429748517

internal/core/converter/tensorflow/tensorflow.go

Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>

kevindiu · 2020-06-03T04:26:12Z

LGTM

kevindiu · 2020-06-03T04:26:21Z

/rebase

vdaas-ci · 2020-06-03T04:26:52Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/tensorflow

hlts2

LGTM

Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>

github-actions · 2020-06-03T05:17:33Z

internal/core/converter/tensorflow/tensorflow.go

 )

+var loadFunc = tf.LoadSavedModel


[golangci] _{reported by reviewdog 🐶}
loadFunc is a global variable (gochecknoglobals)

hlts2

LGTM

kevindiu · 2020-06-03T06:16:50Z

LGTM

vankichi

LGTM

vankichi · 2020-06-04T03:36:20Z

@kpango @rinx
Could you review this PR by 6/9 ? 🙏

kpango

LGTM

github-actions bot added area/internal team/set SET team size/XXL type/test Adding tests priority/low labels May 14, 2020

hlts2 requested changes May 18, 2020

View reviewed changes

hlts2 requested changes May 19, 2020

View reviewed changes

vdaas-ci force-pushed the test/internal/tensorflow branch from 243a570 to 044658c Compare May 20, 2020 06:51

github-actions bot reviewed May 20, 2020

View reviewed changes

kevindiu reviewed May 20, 2020

View reviewed changes

hlts2 reviewed May 25, 2020

View reviewed changes

vdaas-ci force-pushed the test/internal/tensorflow branch from b4a0498 to 4b8448d Compare May 25, 2020 05:37

github-actions bot reviewed May 25, 2020

View reviewed changes

vankichi requested review from hlts2 and kevindiu June 2, 2020 01:58

fix golangci-lint issue

bb536a8

Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>

vdaas-ci force-pushed the test/internal/tensorflow branch from 17304e0 to bb536a8 Compare June 2, 2020 05:25

vankichi mentioned this pull request Jun 3, 2020

Accessing empty slice with no boundary checking causing error #432

Closed

18 tasks

hlts2 reviewed Jun 3, 2020

View reviewed changes

internal/core/converter/tensorflow/tensorflow.go Outdated Show resolved Hide resolved

delete Closer interface

0df8eb0

Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>

kevindiu previously approved these changes Jun 3, 2020

View reviewed changes

hlts2 previously approved these changes Jun 3, 2020

View reviewed changes

fix DeepSource issue: Function literal can be simplified

057e0bd

Signed-off-by: datelier <57349093+datelier@users.noreply.github.com>

datelier dismissed stale reviews from hlts2 and kevindiu via 057e0bd June 3, 2020 05:12

github-actions bot reviewed Jun 3, 2020

View reviewed changes

hlts2 approved these changes Jun 3, 2020

View reviewed changes

kevindiu approved these changes Jun 3, 2020

View reviewed changes

kevindiu requested a review from vankichi June 3, 2020 06:20

vankichi approved these changes Jun 4, 2020

View reviewed changes

vankichi added status/author-review and removed team/set SET team labels Jun 4, 2020

vankichi requested review from kpango and rinx June 4, 2020 03:35

kpango approved these changes Jun 4, 2020

View reviewed changes

Merge branch 'master' into test/internal/tensorflow

001fba7

kpango merged commit 6034bb8 into master Jun 4, 2020

kpango deleted the test/internal/tensorflow branch June 4, 2020 04:52

github-actions bot added the team/set SET team label Jun 4, 2020

	name: "return (value, nil)",
	name: "returns (value, nil) when run function returns nil",

	name: "run() error",
	name: "returns (nil, error) when run function returns `session.Run() error`",

	name: "nil tensor error: run() return nil",
	name: "returns (nil, error) when
	tensors returned by the run function is nil",

	name: "nil tensor error: run() return [nil]",
	name: "returns (nil, error) when
	element of tensors returned by the run function is nil",

	name: "failed to cast error: ndim == TwoDim",
	name: "returns (nil, error) when ndim is `TwoDim` and returns error of `ErrFailedToCastTF",

	name: "failed to cast error: ndim == ThreeDim",
	name: "returns (nil, error) when ndim is `ThreeDim ` and returns error of`ErrFailedToCastTF`",

	name: "failed to cast error: ndim == default",
	name: "returns (nil, error) when ndim is `default ` and returns error of`ErrFailedToCastTF`",

	name: "return ([], nil): inputs == nil",
	name: "return ([], nil) when inputs is nil and Run function returns ([], nil)",

	name: "length error",
	name: "returns (nil, error) when length of inputs and feeds field are different",

	name: "session.Run() error",
	name: "returns (nil, error) when Run function returns error",

	name: "return ([], nil): inputs == {\"test\"}",
	name: "return ([], nil) when inputs is `{"test"} and Run function returns ([], nil)`",

	if t.options == nil && (t.sessionTarget == "" \|\| t.sessionConfig != nil) {
	if t.options == nil && t.sessionTarget == "" {

tensorflow test #378

tensorflow test #378

Conversation

datelier commented May 14, 2020

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented May 14, 2020 • edited Loading

codecov bot commented May 14, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

datelier commented May 20, 2020

rinx commented May 20, 2020

vdaas-ci commented May 20, 2020

github-actions bot May 20, 2020

Choose a reason for hiding this comment

github-actions bot May 20, 2020

Choose a reason for hiding this comment

github-actions bot May 20, 2020

Choose a reason for hiding this comment

github-actions bot May 20, 2020

Choose a reason for hiding this comment

github-actions bot May 20, 2020

Choose a reason for hiding this comment

github-actions bot May 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot May 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot May 20, 2020

Choose a reason for hiding this comment

github-actions bot May 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevindiu commented May 20, 2020

datelier commented May 21, 2020

hlts2 May 25, 2020 • edited Loading

Choose a reason for hiding this comment

datelier commented May 25, 2020

vdaas-ci commented May 25, 2020

github-actions bot May 25, 2020

Choose a reason for hiding this comment

kevindiu commented May 25, 2020

kevindiu commented May 25, 2020

vankichi commented Jun 2, 2020

vdaas-ci commented Jun 2, 2020

vdaas-ci commented Jun 2, 2020

kevindiu commented Jun 2, 2020

kevindiu commented Jun 3, 2020

kevindiu commented Jun 3, 2020

vdaas-ci commented Jun 3, 2020

hlts2 left a comment

Choose a reason for hiding this comment

github-actions bot Jun 3, 2020

Choose a reason for hiding this comment

pull-assistant bot commented May 14, 2020 •

edited

Loading

codecov bot commented May 14, 2020 •

edited

Loading

hlts2 May 25, 2020 •

edited

Loading