Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add topology spread constraints #383

Merged
merged 4 commits into from
May 18, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented May 18, 2020

Description:

  • Added topologySpreadConstraints for pods in each deployment/daemonset/statefulset template
  • Added missing affinity fields in each daemonset template
  • Added notes about topologySpreadConstraints in docs/configurations.md

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.11.4

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

rinx added 2 commits May 18, 2020 12:10
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented May 18, 2020

Score: 0.98

Best reviewed: commit by commit


Optimal code review plan

     ☸️ Add topologySpreadConstraints

     📝 write about pods topology spread constraints

     📝 Revise pod scheduling section

     🤖 Update license headers and formatting go codes

Powered by Pull Assistant. Last update c205697 ... 38c03fb. Read the comment docs.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the feature/helm/add-topology-spread-constraints branch from 75dba6c to 10647ae Compare May 18, 2020 03:45
@rinx
Copy link
Contributor Author

rinx commented May 18, 2020

/format

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

Signed-off-by: vdaas-ci <ci@vdaas.org>
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 895ae0b into master May 18, 2020
@kpango kpango deleted the feature/helm/add-topology-spread-constraints branch May 18, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants