Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] add agent auto save indexing feature #385

Merged
merged 6 commits into from
May 18, 2020

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 18, 2020

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

Add agent auto save index feature

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.11.4

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented May 18, 2020

Score: 0.95

Best reviewed: commit by commit


Optimal code review plan (1 warning)

[patch] add agent auto save indexing feature

internal/config/ngt.go 60% changes removed in fix

     Merge branch 'master' into feature/agent-indexmanager/add-save-index-d...

     fix

     fix

     fix

     fix

Powered by Pull Assistant. Last update 6f344ca ... f3d774b. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

…daemon

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango kpango force-pushed the feature/agent-indexmanager/add-save-index-daemon branch from 58041dc to 0559eaf Compare May 18, 2020 07:32
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango requested a review from rinx May 18, 2020 07:33
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #385 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #385      +/-   ##
=========================================
- Coverage    7.90%   7.89%   -0.01%     
=========================================
  Files         346     346              
  Lines       17804   17823      +19     
=========================================
  Hits         1408    1408              
- Misses      16215   16234      +19     
  Partials      181     181              
Impacted Files Coverage Δ
internal/client/agent/grpc/client.go 0.00% <0.00%> (ø)
internal/client/agent/grpc/option.go 25.00% <ø> (ø)
internal/client/agent/rest/client.go 0.00% <ø> (ø)
internal/client/agent/rest/option.go 25.00% <ø> (ø)
internal/config/ngt.go 0.00% <0.00%> (ø)
pkg/agent/ngt/service/ngt.go 0.00% <0.00%> (ø)
pkg/manager/index/service/indexer.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d42bc...f3d774b. Read the comment docs.

fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@github-actions github-actions bot added the team/set SET team label May 18, 2020
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

charts/vald/values.yaml Outdated Show resolved Hide resolved
pkg/agent/ngt/service/ngt.go Show resolved Hide resolved
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

rinx
rinx previously approved these changes May 18, 2020
Copy link
Contributor

@rinx rinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☕

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango kpango force-pushed the feature/agent-indexmanager/add-save-index-daemon branch from d416ef5 to f3d774b Compare May 18, 2020 08:30
Copy link
Contributor

@rinx rinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again 🍵
Thanks @kpango

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@rinx rinx merged commit d77a453 into master May 18, 2020
@rinx rinx deleted the feature/agent-indexmanager/add-save-index-daemon branch May 18, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants