Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗺 Add app.kubernetes.io/xxx labels to all resources #397

Merged
merged 3 commits into from
May 21, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented May 21, 2020

Description:

Related Issue:

Nothing.

How Has This Been Tested?:

Sure. on my KinD.

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

rinx added 3 commits May 21, 2020 17:01
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     🏷️ Add k8s labels to all resources

     ♻️ Use app.kubernetes.io/{name,component} labels for svc matchL...

     🔧 Make example values-scylla.yaml more lighter

Powered by Pull Assistant. Last update f5a3518 ... 5725a2c. Read the comment docs.

@rinx rinx requested review from a team, hlts2 and vankichi and removed request for a team May 21, 2020 08:56
@rinx rinx requested review from kevindiu and kpango May 21, 2020 08:57
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 4dc987f into master May 21, 2020
@kpango kpango deleted the refactor/helm/add-labels-to-all-resources branch May 21, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants