Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade tools version #399

Merged
merged 5 commits into from
May 22, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented May 22, 2020

Description:

Upgrade tools versions

Related Issue:

Nothing

How Has This Been Tested?:

Nothing

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

rinx added 3 commits May 22, 2020 09:49
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented May 22, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ⬆️ upgrading helm, helm-docs, kind versions

     📝 Fix docs

     💚 test

     Revert ":green_heart: test"

     💚 Revise order of update commands

Powered by Pull Assistant. Last update 91ade23 ... 746f4f6. Read the comment docs.

This reverts commit a13c988.
@rinx rinx marked this pull request as ready for review May 22, 2020 01:27
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx requested review from hlts2 and kpango May 22, 2020 01:35
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit e0d8908 into master May 22, 2020
@kpango kpango deleted the dependencies/tools/upgrade-tools-version-helm-docs-fix branch May 22, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants