Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade Operator SDK version / Remove useless GO111MODULE=off #402

Conversation

rinx
Copy link
Contributor

@rinx rinx commented May 25, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

  • To run make update correctly, remove GO111MODULE=off from several statements in Makefile.d/proto.mk
  • upgrade Operator SDK version

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ⬆️ Upgrade Operator SDK version / Remove useless GO111MODULE=o...

Powered by Pull Assistant. Last update 635ec37 ... 635ec37. Read the comment docs.

@kpango
Copy link
Collaborator

kpango commented May 25, 2020

LGTM

@kpango kpango merged commit fb392fc into master May 25, 2020
@kpango kpango deleted the dependencies/gomods-operator-sdk/remove-no-mod-and-update-operator-sdk-version branch May 25, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants