Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document to deploy standalone agent #407

Merged
merged 20 commits into from
Jun 5, 2020
Merged

Document to deploy standalone agent #407

merged 20 commits into from
Jun 5, 2020

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented May 26, 2020

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I created document to deploy standaline agent.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented May 26, 2020 •
edited
Loading

Score: 0.75

Best reviewed: commit by commit

Optimal code review plan (4 warnings)

     feat: docs to deploy standalone agent

feat: added docs

docs/user/get-started.md 52% changes removed in fix: k8s to kubernet...

feat: added example configuration and code

docs/user/get-started.md 80% changes removed in fix: apply suggestio...

feat: added example code to document

docs/user/get-started.md 71% changes removed in fix: apply suggestio...

     fix: deleted unnesessary step

     feat: added title contents

fix: apply suggestion

docs/user/get-started.md 75% changes removed in fix: apply suggestio...

     fix: delete unnessesary file

     fix: k8s to kubernetes

     fix: feedback

     fix: apply suggestion

     fix: apply suggestion

     fix: missing word

     fix: apply suggestion

     fix: apply suggestion

     fix: comment

     fix: golang to Go

     Delete go.mod

     Delete go.sum

     fix: apply suggestion

Powered by Pull Assistant. Last update d74bf10 ... 0b78019. Read the comment docs.

@hlts2
Copy link
Contributor Author

hlts2 commented May 26, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: documentation/get_started_doc

@vdaas-ci vdaas-ci force-pushed the documentation/get_started_doc branch from 3b207c0 to 4779e14 Compare May 26, 2020 09:41
@hlts2
Copy link
Contributor Author

hlts2 commented Jun 1, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 1, 2020

[REBASE] Rebase triggered by hlts2 for branch: documentation/get_started_doc

@vdaas-ci vdaas-ci force-pushed the documentation/get_started_doc branch from 803a7a1 to 36fabed Compare June 1, 2020 00:07
@hlts2
Copy link
Contributor Author

hlts2 commented Jun 1, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 1, 2020

[REBASE] Rebase triggered by hlts2 for branch: documentation/get_started_doc

@vdaas-ci vdaas-ci force-pushed the documentation/get_started_doc branch from 36fabed to 74ae6ab Compare June 1, 2020 08:52
@hlts2
Copy link
Contributor Author

hlts2 commented Jun 2, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 2, 2020

[REBASE] Rebase triggered by hlts2 for branch: documentation/get_started_doc

@hlts2 hlts2 requested a review from kevindiu June 2, 2020 03:41
@hlts2 hlts2 self-assigned this Jun 2, 2020
@github-actions github-actions bot added size/XL and removed size/L labels Jun 2, 2020
kevindiu
kevindiu reviewed Jun 3, 2020
View reviewed changes
docs/user/get-started.md Outdated Show resolved Hide resolved
docs/user/get-started.md Outdated Show resolved Hide resolved
docs/user/get-started.md Outdated Show resolved Hide resolved
docs/user/get-started.md Outdated Show resolved Hide resolved
example/client/agent/go.mod Outdated Show resolved Hide resolved
example/client/agent/main.go Show resolved Hide resolved
@hlts2
Copy link
Contributor Author

hlts2 commented Jun 3, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 3, 2020

[REBASE] Rebase triggered by hlts2 for branch: documentation/get_started_doc

@vdaas-ci vdaas-ci force-pushed the documentation/get_started_doc branch from f29fa84 to be6b235 Compare June 3, 2020 03:06
@hlts2
Copy link
Contributor Author

hlts2 commented Jun 3, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 3, 2020

[REBASE] Rebase triggered by hlts2 for branch: documentation/get_started_doc

kevindiu
kevindiu reviewed Jun 3, 2020
View reviewed changes
docs/user/get-started.md Outdated Show resolved Hide resolved
kevindiu
kevindiu reviewed Jun 3, 2020
View reviewed changes
docs/user/get-started.md Show resolved Hide resolved
docs/user/get-started.md Show resolved Hide resolved
kevindiu
kevindiu reviewed Jun 3, 2020
View reviewed changes
docs/user/get-started.md Outdated Show resolved Hide resolved
docs/user/get-started.md Outdated Show resolved Hide resolved
docs/user/get-started.md Outdated Show resolved Hide resolved
@vankichi
Copy link
Contributor

vankichi commented Jun 4, 2020

@hlts2 please fix indent 🙏

@hlts2
Copy link
Contributor Author

hlts2 commented Jun 5, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 5, 2020

[REBASE] Rebase triggered by hlts2 for branch: documentation/get_started_doc

hlts2 and others added 19 commits June 5, 2020 04:47
@hlts2 @actions-user
feat: docs to deploy standalone agent
d74bf10 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: added docs
91d28df 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: added example configuration and code
a5eaae7 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: added example code to document
2bc6c02 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: deleted unnesessary step
5c551f1 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
feat: added title contents
81b3c8e 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply suggestion
f07ae07 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: delete unnessesary file
3bf0874 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: k8s to kubernetes
357e0eb 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: feedback
6270596 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply suggestion
d11b707 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply suggestion
ace871f 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: missing word
28daab6 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply suggestion
2e91646 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: apply suggestion
6a8c153 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: comment
52add4b 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: golang to Go
21a5f52 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@actions-user
Delete go.mod
0940b96
@actions-user
Delete go.sum
c0006b5
@vdaas-ci vdaas-ci force-pushed the documentation/get_started_doc branch from 5ed805f to c0006b5 Compare June 5, 2020 04:47
@github-actions github-actions bot added size/L and removed size/L labels Jun 5, 2020
@hlts2
fix: apply suggestion
0b78019 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kevindiu
kevindiu approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve
/rebase
/approve

@vankichi vankichi merged commit fc9995a into master Jun 5, 2020
@vankichi vankichi deleted the documentation/get_started_doc branch June 5, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindiu kevindiu kevindiu approved these changes

@vankichi vankichi vankichi approved these changes

Assignees

@hlts2 hlts2

Labels
priority/low size/XL type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlts2 @vdaas-ci @vankichi @kevindiu