Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [patch] divide gateway #425

Closed
wants to merge 18 commits into from
Closed

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 31, 2020

Signed-off-by: kpango i.can.feel.gravity@gmail.com

WIP

please do not review for now

Description

This PR includes a lot of feature.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented May 31, 2020

Score: 0.94

Best reviewed: commit by commit


Optimal code review plan (2 warnings)

[patch] divide gateway

...y/backup/router/router_test.go 75% changes removed in fix

...y/filter/router/router_test.go 75% changes removed in fix

...teway/lb/router/router_test.go 75% changes removed in fix

...way/meta/router/router_test.go 75% changes removed in fix

     [patch] divide gateway

     🤖 Update license headers / Format go codes and yaml files

     Update charts/vald/templates/gateway/meta/deployment.yaml

     Update charts/vald/templates/gateway/meta/daemonset.yaml

     Update charts/vald/templates/gateway/lb/deployment.yaml

     Update charts/vald/templates/gateway/lb/daemonset.yaml

     Update charts/vald/templates/gateway/filter/deployment.yaml

     Update charts/vald/templates/gateway/filter/daemonset.yaml

     Update charts/vald/templates/gateway/backup/deployment.yaml

Update charts/vald/templates/gateway/backup/daemonset.yaml

...handler/grpc/checklist_test.go 50% changes removed in fix

...way/lb/handler/grpc/handler.go 73% changes removed in fix

...y/backup/router/router_test.go 50% changes removed in fix

...teway/lb/router/router_test.go 50% changes removed in fix

...y/meta/handler/grpc/handler.go 64% changes removed in fix

...way/meta/router/router_test.go 50% changes removed in fix

...y/filter/router/router_test.go 50% changes removed in fix

...g/gateway/lb/service/backup.go 50% changes removed in fix

...ay/vald/service/backup_test.go 60% changes removed in fix

     fix

     fix

     fix

     fix

     fix

     Merge branch 'master' into feature/gateway/divide-gateway

     fix

Powered by Pull Assistant. Last update fa0f587 ... 8b97f7d. Read the comment docs.

@kpango
Copy link
Collaborator Author

kpango commented May 31, 2020

/rebase
/format

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: feature/gateway/divide-gateway

@vdaas-ci
Copy link
Collaborator

[REBASE] Failed to rebase.

@kpango kpango force-pushed the feature/gateway/divide-gateway branch from 3b1961e to 2dd0c27 Compare May 31, 2020 08:12
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango
Copy link
Collaborator Author

kpango commented May 31, 2020

/format

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #425 into master will decrease coverage by 0.70%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #425      +/-   ##
=========================================
- Coverage    9.18%   8.47%   -0.71%     
=========================================
  Files         402     431      +29     
  Lines       20859   22743    +1884     
=========================================
+ Hits         1916    1928      +12     
- Misses      18690   20550    +1860     
- Partials      253     265      +12     
Impacted Files Coverage Δ
cmd/gateway/lb/main.go 0.00% <0.00%> (ø)
hack/license/gen/main.go 0.00% <ø> (ø)
internal/client/agent/grpc/client.go 0.00% <0.00%> (ø)
internal/client/gateway/vald/grpc/client.go 0.00% <0.00%> (ø)
internal/config/ngt.go 0.00% <ø> (ø)
internal/errors/grpc.go 0.00% <0.00%> (ø)
internal/errors/ngt.go 0.00% <0.00%> (ø)
internal/errors/runtime.go 0.00% <0.00%> (ø)
internal/net/grpc/pool/pool.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/handler.go 0.00% <0.00%> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bbd2e...8b97f7d. Read the comment docs.

Copy link
Contributor

@rinx rinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are introduced in #409. Please include them.

@kpango kpango force-pushed the feature/gateway/divide-gateway branch from 9c3da1b to 80d8d30 Compare May 31, 2020 08:22
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

8 similar comments
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango force-pushed the feature/gateway/divide-gateway branch from b9b1cb1 to f354295 Compare May 31, 2020 17:04
@kpango kpango force-pushed the feature/gateway/divide-gateway branch from 49b6bb4 to fcdbebf Compare June 16, 2020 10:13
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango force-pushed the feature/gateway/divide-gateway branch from fcdbebf to 10df3a7 Compare June 18, 2020 08:34
@vdaas-ci
Copy link
Collaborator

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango force-pushed the feature/gateway/divide-gateway branch 5 times, most recently from 032a1df to 840211d Compare June 26, 2020 11:50
kpango and others added 16 commits July 2, 2020 13:44
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Signed-off-by: vdaas-ci <ci@vdaas.org>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango kpango force-pushed the feature/gateway/divide-gateway branch from 62a75b1 to 208e50d Compare July 2, 2020 04:54
Yusuke Kato added 2 commits July 2, 2020 13:56
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango kpango closed this Jul 2, 2020
@kpango kpango deleted the feature/gateway/divide-gateway branch July 2, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants