Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improve discoverer function #429

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jun 1, 2020

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

Discoverer may blocking discover process. So I delete the fch channel and added init error code.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Jun 1, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix: delete fch channel because fch causes channel blocking

Powered by Pull Assistant. Last update 8c50090 ... 8c50090. Read the comment docs.

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 changed the title Fix: improve discover function Fix: improve discoverer function Jun 1, 2020
@kpango kpango merged commit 935170a into master Jun 1, 2020
@kpango kpango deleted the bug/internal/discover_blocking branch June 1, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants