Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the component section from architecture doc #430

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Separate the component section from architecture doc #430

merged 3 commits into from
Jun 2, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 1, 2020 •
edited
Loading

Description:

This PR separate the component section from architecture document.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 1, 2020 •
edited
Loading

Score: 0.77

Best reviewed: commit by commit

Optimal code review plan

     move components section from architecture page to new page

     fix ident and add overview description to components page

     Apply suggestions from code review

Powered by Pull Assistant. Last update fa68533 ... 1dcf8b8. Read the comment docs.

@kevindiu kevindiu changed the title Documentation/component Move component section from architecture doc Jun 1, 2020
@kevindiu kevindiu added size/M and removed size/L labels Jun 1, 2020
@kevindiu kevindiu changed the title Move component section from architecture doc Separate the component section from architecture doc Jun 1, 2020
vankichi
vankichi previously approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu @hlts2
Apply suggestions from code review
1dcf8b8 
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot added size/L and removed size/M labels Jun 1, 2020
hlts2
hlts2 previously approved these changes Jun 1, 2020
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Jun 1, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 1, 2020

[REBASE] Rebase triggered by vankichi for branch: documentation/component

vankichi
vankichi previously approved these changes Jun 1, 2020
View reviewed changes
@vankichi vankichi marked this pull request as ready for review June 1, 2020 09:04
@kevindiu kevindiu requested review from kpango, kmrmt and rinx June 1, 2020 09:04
@vankichi
Copy link
Contributor

vankichi commented Jun 1, 2020

/approve
/rebase
/format

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 1, 2020

[REBASE] Rebase triggered by vankichi for branch: documentation/component

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 1, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and hlts2 via 2780953 June 1, 2020 09:08
vdaas-ci
vdaas-ci previously approved these changes Jun 1, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@kevindiu
Copy link
Contributor Author

kevindiu commented Jun 1, 2020

/approve

@vankichi
Copy link
Contributor

vankichi commented Jun 2, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 2, 2020

[REBASE] Rebase triggered by vankichi for branch: documentation/component

kmrmt
kmrmt approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@kmrmt kmrmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit 41fe484 into master Jun 2, 2020
@vankichi vankichi deleted the documentation/component branch June 2, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmrmt kmrmt kmrmt approved these changes

@vdaas-ci vdaas-ci vdaas-ci left review comments

@hlts2 hlts2 hlts2 left review comments

@vankichi vankichi vankichi left review comments

@kpango kpango Awaiting requested review from kpango

@rinx rinx Awaiting requested review from rinx

Assignees
No one assigned
Labels
priority/low size/L type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevindiu @vankichi @vdaas-ci @kmrmt @hlts2