Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍱 update architecture overview svg to add agent sidecar #437

Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 4, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Update architecture overview svg. added agent sidecar.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 4, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     🍱 update architecture overview svg to add agent sidecar

Powered by Pull Assistant. Last update d81aa01 ... d81aa01. Read the comment docs.

@rinx rinx force-pushed the documentation/architecture-overviwe/update-svg-agent-sidecar branch from 9f301fb to e29c9bf Compare June 4, 2020 02:49
@rinx
Copy link
Contributor Author

rinx commented Jun 4, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 4, 2020

[REBASE] Rebase triggered by rinx for branch: documentation/architecture-overviwe/update-svg-agent-sidecar

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the documentation/architecture-overviwe/update-svg-agent-sidecar branch from e29c9bf to d81aa01 Compare June 4, 2020 02:53
@kpango
Copy link
Collaborator

kpango commented Jun 4, 2020

LGTM

@kpango kpango merged commit 48e92aa into master Jun 4, 2020
@kpango kpango deleted the documentation/architecture-overviwe/update-svg-agent-sidecar branch June 4, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants