Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent wording #442

Merged
merged 13 commits into from
Jun 8, 2020
Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jun 8, 2020

Description:

I fixed inconsistent wording about kubernetes and Go.
For example, I change from k8s to Kubernetes and golang to Go.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 8, 2020

Score: 0.74

Best reviewed: commit by commit


Optimal code review plan (1 warning)

fix: inconsistent speling about kubernetes and go

docs/developer/style.md 85% changes removed in fix: apply suggestio...

     fix: inconsistent speling about kubernetes and go

     fix: Undo

     fix: Undo

     fix: k8s to kubernetes

     fix: version of kubernetes and Go

     fix: version of NGT

     fix: undo ngt version

     fix: update ngt and k8s and go version

     fix: automatically update issue template

     fix: Golang -> Go

     fix: apply suggestion

     fix: apply suggestion

Powered by Pull Assistant. Last update 8108078 ... 181b423. Read the comment docs.

@hlts2 hlts2 changed the title [WIP] Fix inconsistent spelling [Draft] Fix inconsistent spelling Jun 8, 2020
@kpango
Copy link
Collaborator

kpango commented Jun 8, 2020

could you please update go version and k8s version about each template?

@rinx
Copy link
Contributor

rinx commented Jun 8, 2020

@hlts2 Please update the workflow to work correctly.

sed -i -e "s/^- Golang Version: .*$/- Golang Version: ${GO_VERSION}/" .github/PULL_REQUEST_TEMPLATE.md

I recommend to add sed commands to update issue template at the same time.

kevindiu
kevindiu previously approved these changes Jun 8, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu
Copy link
Contributor

kevindiu commented Jun 8, 2020

@hlts2 Please update the workflow to work correctly.

sed -i -e "s/^- Golang Version: .*$/- Golang Version: ${GO_VERSION}/" .github/PULL_REQUEST_TEMPLATE.md

I recommend to add sed commands to update issue template at the same time.

should we include this changes in this PR?

@hlts2 hlts2 changed the title [Draft] Fix inconsistent spelling [Draft] Fix inconsistent wording Jun 8, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 changed the title [Draft] Fix inconsistent wording Fix inconsistent wording Jun 8, 2020
@hlts2 hlts2 marked this pull request as ready for review June 8, 2020 06:56
rinx
rinx previously approved these changes Jun 8, 2020
Copy link
Contributor

@rinx rinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@hlts2 hlts2 requested review from kevindiu and vankichi June 8, 2020 07:35
kevindiu
kevindiu previously approved these changes Jun 8, 2020
@hlts2 hlts2 self-assigned this Jun 8, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hlts2 please check it.

charts/vald/README.md Show resolved Hide resolved
charts/vald/README.md.gotmpl Show resolved Hide resolved
docs/developer/style.md Outdated Show resolved Hide resolved
@hlts2 hlts2 dismissed stale reviews from kevindiu and rinx via dccad0a June 8, 2020 07:44
kevindiu
kevindiu previously approved these changes Jun 8, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2
Copy link
Collaborator Author

hlts2 commented Jun 8, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 8, 2020

[REBASE] Rebase triggered by hlts2 for branch: documentation/fix_inconsistent_spelling

hlts2 added 13 commits June 8, 2020 08:22
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci vdaas-ci force-pushed the documentation/fix_inconsistent_spelling branch from 65b2fd1 to 181b423 Compare June 8, 2020 08:22
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FYI I re-reviewed this PR using the following command to grep the wordings.

rg -a golang ./ -o -l -T go
rg -a k8s ./ -o -l -T go

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve
/rebase
/approve

@vankichi vankichi merged commit 3b3ef0f into master Jun 8, 2020
@vankichi vankichi deleted the documentation/fix_inconsistent_spelling branch June 8, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants