Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog command (ChatOps) #447

Merged
merged 8 commits into from
Jun 8, 2020
Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 8, 2020

Description:

  • Updated CHANGELOG since v0.0.30.
  • Added ChatOps feature /changelog.
  • Updated semver workflow.

Related Issue:

Nothing.

How Has This Been Tested?:

Not yet. the first release after this PR merged may fail..

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 8, 2020

Score: 0.88

Best reviewed: commit by commit


Optimal code review plan

     💄 Reformat CHANGELOG.md

     📝 Add missing CHANGELOGs

     ✨ Add Changelog template

     ✨ Add auto-update feature of CHANGELOG

     🚀 Add changelog permissions

     🤖 Update license headers / Format go codes and yaml files

     ✨ add links

     📝 Add links to prs

Powered by Pull Assistant. Last update 70b2a99 ... 6850a43. Read the comment docs.

@rinx rinx changed the title Ci/chatops/add changelog command Add changelog command (ChatOps) Jun 8, 2020
@rinx
Copy link
Contributor Author

rinx commented Jun 8, 2020

/rebase
/format

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 8, 2020

[REBASE] Rebase triggered by rinx for branch: ci/chatops/add-changelog-command

rinx added 5 commits June 8, 2020 09:15
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the ci/chatops/add-changelog-command branch from bb3e63e to 8bf18a8 Compare June 8, 2020 09:15
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 8, 2020

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

@rinx rinx marked this pull request as ready for review June 8, 2020 09:19
rinx added 2 commits June 8, 2020 18:59
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 5c3d891 into master Jun 8, 2020
@kpango kpango deleted the ci/chatops/add-changelog-command branch June 8, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants