Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loadtest job and container #449

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jun 8, 2020

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

add loadtest docker image and job

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 8, 2020

Score: 0.99

Best reviewed: commit by commit


Optimal code review plan

     add loadtest job and container

     fix

     fix

     Apply suggestions from code review

Powered by Pull Assistant. Last update 9d074bc ... 975f5e8. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #449   +/-   ##
======================================
  Coverage    7.82%   7.82%           
======================================
  Files         389     389           
  Lines       20003   20003           
======================================
  Hits         1565    1565           
  Misses      18214   18214           
  Partials      224     224           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22b594a...975f5e8. Read the comment docs.

@kpango kpango force-pushed the feature/loadtest/add-load-test-docker branch from 42ee1d4 to 3b23750 Compare June 8, 2020 16:05
@github-actions github-actions bot added size/L and removed size/M labels Jun 8, 2020
@kpango kpango force-pushed the feature/loadtest/add-load-test-docker branch from 3b23750 to 659a3ef Compare June 8, 2020 16:12
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango kpango force-pushed the feature/loadtest/add-load-test-docker branch from 659a3ef to 9d074bc Compare June 8, 2020 16:15
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
.github/workflows/dockers-loadtest-image.yml Outdated Show resolved Hide resolved
dockers/tools/cli/loadtest/Dockerfile Show resolved Hide resolved
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango kpango requested a review from rinx June 9, 2020 01:05
Makefile.d/docker.mk Outdated Show resolved Hide resolved
k8s/tools/cli/loadtest/cronjob.yaml Outdated Show resolved Hide resolved
k8s/tools/cli/loadtest/cronjob.yaml Outdated Show resolved Hide resolved
k8s/tools/cli/loadtest/cronjob.yaml Show resolved Hide resolved
k8s/tools/cli/loadtest/job.yaml Outdated Show resolved Hide resolved
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@kpango kpango requested a review from rinx June 9, 2020 01:21
@rinx
Copy link
Contributor

rinx commented Jun 9, 2020

/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2020

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2020

[FORMAT] Failed to format.

@kpango kpango merged commit 7026a89 into master Jun 9, 2020
@kpango kpango deleted the feature/loadtest/add-load-test-docker branch June 9, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants