Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test template bug #452

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Fix test template bug #452

merged 2 commits into from
Jun 9, 2020

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jun 9, 2020 •
edited
Loading

Description:

The error occurred when I uncommented it, so I fixed the template.
In this PR, I only modified the test template.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 9, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     fix: template bug

     fix: comment

Powered by Pull Assistant. Last update 7ad9da1 ... 6d10e1a. Read the comment docs.

@hlts2 hlts2 requested a review from kevindiu June 9, 2020 03:32
@hlts2 hlts2 self-assigned this Jun 9, 2020
@github-actions github-actions bot added size/S type/bug Something isn't working priority/medium labels Jun 9, 2020
kevindiu
kevindiu previously approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 requested a review from vankichi June 9, 2020 03:53
vankichi
vankichi previously approved these changes Jun 9, 2020
View reviewed changes
@vankichi
Copy link
Contributor

vankichi commented Jun 9, 2020

/approve
/rebase
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2020

[REBASE] Rebase triggered by vankichi for branch: bug/assets/fix_test_template

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and kevindiu via 97c3e68 June 9, 2020 08:33
@vdaas-ci vdaas-ci force-pushed the bug/assets/fix_test_template branch from 2425170 to 97c3e68 Compare June 9, 2020 08:33
vdaas-ci
vdaas-ci previously approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi
Copy link
Contributor

vankichi commented Jun 9, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2020

[REBASE] Rebase triggered by vankichi for branch: bug/assets/fix_test_template

hlts2 added 2 commits June 9, 2020 08:43
@hlts2 @actions-user
fix: template bug
7ad9da1 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: comment
6d10e1a 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci vdaas-ci force-pushed the bug/assets/fix_test_template branch from 97c3e68 to 6d10e1a Compare June 9, 2020 08:43
@vankichi
Copy link
Contributor

vankichi commented Jun 9, 2020

/approve

vdaas-ci
vdaas-ci approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 70df75d into master Jun 9, 2020
@vankichi vankichi deleted the bug/assets/fix_test_template branch June 9, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@vankichi vankichi vankichi left review comments

@kevindiu kevindiu kevindiu left review comments

Assignees

@hlts2 hlts2

Labels
priority/medium size/S type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlts2 @vankichi @vdaas-ci @kevindiu