Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal/log/level pacakge test #455

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Fix internal/log/level pacakge test #455

merged 1 commit into from
Jun 9, 2020

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jun 9, 2020 •
edited
Loading

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I fixed internal/log/level pacakge based on generated test code.
this code's coverage is 100%.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@hlts2 hlts2 requested a review from kevindiu June 9, 2020 08:22
@pull-assistant
Copy link

pull-assistant bot commented Jun 9, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     feat: level pacakge test

Powered by Pull Assistant. Last update 515abd6 ... 515abd6. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #455 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #455      +/-   ##
=========================================
+ Coverage    7.84%   7.88%   +0.04%     
=========================================
  Files         388     388              
  Lines       19945   19945              
=========================================
+ Hits         1565    1573       +8     
+ Misses      18156   18148       -8     
  Partials      224     224
Impacted Files Coverage Δ
internal/log/level/level.go 100.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa0524...515abd6. Read the comment docs.

kevindiu
kevindiu previously approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi previously approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Jun 9, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/log_level

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and kevindiu via 6e40274 June 9, 2020 08:49
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2020

[FORMAT] Failed to format.

@vankichi
Copy link
Contributor

vankichi commented Jun 9, 2020

/approve

vdaas-ci
vdaas-ci previously approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi
Copy link
Contributor

vankichi commented Jun 9, 2020

/rebase
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/log_level

vdaas-ci
vdaas-ci previously approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi
Copy link
Contributor

vankichi commented Jun 9, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/log_level

@hlts2 @actions-user
feat: level pacakge test
515abd6 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vankichi
Copy link
Contributor

vankichi commented Jun 9, 2020

/approve

@vankichi vankichi merged commit 2c31926 into master Jun 9, 2020
@vankichi vankichi deleted the test/internal/log_level branch June 9, 2020 09:41
vdaas-ci
vdaas-ci approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@vankichi vankichi vankichi left review comments

@kevindiu kevindiu kevindiu left review comments

Assignees
No one assigned
Labels
area/internal priority/low size/L team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlts2 @vankichi @vdaas-ci @kevindiu