Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix document and added png images #456

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jun 9, 2020

Description:

I fixed some details of document and added png images for getting good performance in public document site:

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Jun 9, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     📝 fix link path

     🎨 add png architecture images

Powered by Pull Assistant. Last update 2fe51c2 ... 24e46a5. Read the comment docs.

@vankichi vankichi changed the title [patch] document fix document and added png images [patch] fix document and added png images Jun 9, 2020
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi changed the title [patch] fix document and added png images fix document and added png images Jun 9, 2020
@kpango kpango merged commit 83daf4b into master Jun 9, 2020
@kpango kpango deleted the documentation/docs/fix-link-path-and-add-png-image branch June 9, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants